mac: Almost fix Lion accented character bubble input in web contents.

content/browser/renderer_host/render_widget_host_view_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_mac.h"
 
 #include <QuartzCore/QuartzCore.h>
 
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
@@ skipping 2452 matching lines @@
   // * when we type an ASCII character (without using input methods).
   // When we aren't using input methods, we should send the given character as
   // a Char event so it is dispatched to an onkeypress() event handler of
   // JavaScript.
   // On the other hand, when we are using input methods, we should send the
   // given characters as an input method event and prevent the characters from
   // being dispatched to onkeypress() event handlers.
   // Text inserting might be initiated by other source instead of keyboard
   // events, such as the Characters dialog. In this case the text should be
   // sent as an input method event as well.
   // TODO(suzhe): It's hard for us to support replacementRange without accessing

[Avi (use Gerrit), 2011/10/12 00:22:09]

Is this comment meaningful?

[Nico, 2011/10/12 00:23:18]

I don't know what it means. Maybe it makes sense for suzhe though :-)

[Avi (use Gerrit), 2011/10/12 00:29:27]

Well, this patch _does_ implement replacementRange without accessing full web
content, in direct contradiction to this comment.

[Nico, 2011/10/12 00:34:30]

Only in the IME case, though.

-  // the full web content. NOTE: If someone adds support for this, make sure
-  // it works with the default range passed in by -insertText: below.
+  // the full web content.
   BOOL isAttributedString = [string isKindOfClass:[NSAttributedString class]];
   NSString* im_text = isAttributedString ? [string string] : string;
   if (handlingKeyDown_) {
     textToBeInserted_.append(base::SysNSStringToUTF16(im_text));
   } else {
+    ui::Range replacement_range(replacementRange);
     renderWidgetHostView_->render_widget_host_->ImeConfirmComposition(
-        base::SysNSStringToUTF16(im_text));
+        base::SysNSStringToUTF16(im_text), replacement_range);
   }
 
   // Inserting text will delete all marked text automatically.
   hasMarkedText_ = NO;
 }
 
 - (void)insertText:(id)string {
   // This is a method on NSTextInput, not NSTextInputClient. But on 10.5, this
   // gets called anyway. Forward to the right method. http://crbug.com/47890
-  [self insertText:string replacementRange:NSMakeRange(0, 0)];
+  [self insertText:string replacementRange:NSMakeRange(NSNotFound, 0)];
 }
 
 - (void)viewDidMoveToWindow {
   if (canBeKeyView_) {
     NSWindow* newWindow = [self window];
     // Pointer comparison only, since we don't know if lastWindow_ is still
     // valid.
     if (newWindow) {
       // If we move into a new window, refresh the frame information. We
       // don't need to do it if it was the same window as it used to be in,
@@ skipping 206 matching lines @@
   if (!string) return NO;
 
   // If the user is currently using an IME, confirm the IME input,
   // and then insert the text from the service, the same as TextEdit and Safari.
   [self confirmComposition];
   [self insertText:string];
   return YES;
 }
 
 @end