Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 822663003: Conform selector used in focus manager of history to <cr-menu> element. (Closed)

Created:
6 years ago by fukino
Modified:
6 years ago
Reviewers:
Dan Beam
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Conform selector used in focus manager of history to <cr-menu> element. The issue was caused by a oversight of crrev.com/805713003. As the menu was not treated as focus parent, 'focus' event was dispatched with the text-field as an target. This make the menu hidden just after the menu is shown. This CL corrects the selector to make the menu focus parent. BUG=444480 TEST=go through repro steps written in the issue Committed: https://crrev.com/908f1466ebf48a6680b4ffede882c8bd64553965 Cr-Commit-Position: refs/heads/master@{#309610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/history/history_focus_manager.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
fukino
@dbeam: PTAL the CL? I'm sorry I overlooked an occurrence of 'menu' in crrev.com/805713003. I ...
6 years ago (2014-12-22 10:26:00 UTC) #2
Dan Beam
lgtm
6 years ago (2014-12-22 19:22:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/822663003/1
6 years ago (2014-12-24 02:47:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-24 03:34:02 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-24 03:34:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/908f1466ebf48a6680b4ffede882c8bd64553965
Cr-Commit-Position: refs/heads/master@{#309610}

Powered by Google App Engine
This is Rietveld 408576698