LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html - Issue 822593003: ServiceWorker: Expose registration within ServiceWorkerGlobalScope [3/3]

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/registration-attribute.html

Issue 822593003: ServiceWorker: Expose registration within ServiceWorkerGlobalScope [3/3] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@expose_swreg

Patch Set: address falken@'s comment Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/registration-attribute-worker.js » ('j') | LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/registration-attribute-worker.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>ServiceWorkerGlobalScope: registration</title>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script src="../resources/test-helpers.js"></script>

	6 <script>

	7

	8 promise_test(function(t) {

	9 var script = "resources/registration-attribute-worker.js";

	10 var scope = "resources/scope/registration-attribute";
	falken 2015/01/27 04:08:15 nit: single-quotes for javascript strings nit: single-quotes for javascript strings nhiroki 2015/01/27 07:51:26 Done. Show quoted text On 2015/01/27 04:08:15, falken wrote: > nit: single-quotes for javascript strings Done.
	11

	12 return navigator.serviceWorker.register(script, {scope: scope})
	falken 2015/01/27 04:08:15 nit: we typically do unregister_and_register() in nit: we typically do unregister_and_register() in the beginning of the test nhiroki 2015/01/27 07:51:26 Done. Show quoted text On 2015/01/27 04:08:15, falken wrote: > nit: we typically do unregister_and_register() in the beginning of the test Done.
	13 .then(function(registration) {

	14 return wait_for_state(t, registration.installing, 'activated');

	15 })

	16 .then(function() { return with_iframe(scope); })

	17 .then(function(frame) {

	18 assert_equals(

	19 frame.contentDocument.body.textContent,

	20 'Hello, world!',

	21 'Service Worker should respond to fetch');

	22 frame.remove();

	23 return service_worker_unregister_and_done(t, scope);

	24 });

	25 }, 'Verify registration attribute on ServiceWorkerGlobalScope');

	26

	27 </script>

OLD	NEW