Issue 822533002: generate_dump, exception_port_tool: set SecTaskAccess allowed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 822533002: generate_dump, exception_port_tool: set SecTaskAccess allowed (Closed)

Created:
6 years ago by Mark Mentovai

Modified:
5 years, 11 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

generate_dump, exception_port_tool: set SecTaskAccess allowed. This adds an Info.plist to these two tools that use task_for_pid(). Since they’re flat unbundled executables, the Info.plist must be placed as a __TEXT,__info_plist section. By setting SecTaskAccess to allowed and signing these tools with a certificate trusted by the system, they will be allowed to use task_for_pid() without requiring the invoking user to be root. This provides an alternative to installing these tools as setuid root. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/3ee656605175deccd14bf6a8d534f8ef55bc0003

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -8 lines)			Patch
M	tools/generate_dump.ad	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	tools/mac/exception_port_tool.ad	View	1 chunk	+5 lines, -4 lines	0 comments	Download
A	tools/mac/sectaskaccess_info.plist	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	tools/tools.gyp	View	3 chunks	+43 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mark Mentovai

5 years, 11 months ago (2014-12-30 19:28:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3ee656605175deccd14bf6a8d534f8ef55bc0003 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages