Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: tests/git_cl_test.py

Issue 822503005: Support --target-branch option to git-cl upload for Rietveld (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: address comment Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/git_cl_test.py
diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index 36730bcd6234203f99ec7f6e690ff0eac679e602..42231e9dfb01d6e7c9d047105e01418dbb029f95 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -756,6 +756,57 @@ class TestGitCl(TestCase):
actual.append(obj.description)
self.assertEqual(expected, actual)
+ def test_get_target_ref(self):
+ # Check remote or remote branch not present.
+ self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'master', None))
+ self.assertEqual(None, git_cl.GetTargetRef(None,
+ 'refs/remotes/origin/master',
+ 'master', None))
+
+ # Check default target refs for branches.
+ self.assertEqual('refs/heads/master',
+ git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
+ None, None))
+ self.assertEqual('refs/heads/master',
+ git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
+ None, None))
+ self.assertEqual('refs/heads/master',
+ git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
+ None, None))
+ self.assertEqual('refs/branch-heads/123',
+ git_cl.GetTargetRef('origin',
+ 'refs/remotes/branch-heads/123',
+ None, None))
+ self.assertEqual('refs/diff/test',
+ git_cl.GetTargetRef('origin',
+ 'refs/remotes/origin/refs/diff/test',
+ None, None))
+
+ # Check target refs for user-specified target branch.
+ for branch in ('branch-heads/123', 'remotes/branch-heads/123',
+ 'refs/remotes/branch-heads/123'):
+ self.assertEqual('refs/branch-heads/123',
+ git_cl.GetTargetRef('origin',
+ 'refs/remotes/origin/master',
+ branch, None))
+ for branch in ('origin/master', 'remotes/origin/master',
+ 'refs/remotes/origin/master'):
+ self.assertEqual('refs/heads/master',
+ git_cl.GetTargetRef('origin',
+ 'refs/remotes/branch-heads/123',
+ branch, None))
+ for branch in ('master', 'heads/master', 'refs/heads/master'):
+ self.assertEqual('refs/heads/master',
+ git_cl.GetTargetRef('origin',
+ 'refs/remotes/branch-heads/123',
+ branch, None))
+
+ # Check target refs for pending prefix.
+ self.assertEqual('prefix/heads/master',
+ git_cl.GetTargetRef('origin', 'refs/remotes/origin/master',
+ None, 'prefix/'))
+
+
if __name__ == '__main__':
git_cl.logging.basicConfig(
level=git_cl.logging.DEBUG if '-v' in sys.argv else git_cl.logging.ERROR)
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698