Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: chromeos/accelerometer/accelerometer_reader.cc

Issue 822503003: Change AccelerometerReader to a Singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/accelerometer/accelerometer_reader.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/accelerometer/accelerometer_reader.cc
diff --git a/chromeos/accelerometer/accelerometer_reader.cc b/chromeos/accelerometer/accelerometer_reader.cc
index 340ba18856cddb06727db4dac7781ba448c1fc05..c0644aa34c5a6ffe5addb4a00ad6d69b46840740 100644
--- a/chromeos/accelerometer/accelerometer_reader.cc
+++ b/chromeos/accelerometer/accelerometer_reader.cc
@@ -9,6 +9,7 @@
#include "base/bind.h"
#include "base/files/file_util.h"
#include "base/location.h"
+#include "base/memory/singleton.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
@@ -183,12 +184,10 @@ AccelerometerReader::ConfigurationData::ConfigurationData()
AccelerometerReader::ConfigurationData::~ConfigurationData() {
}
-AccelerometerReader::AccelerometerReader()
- : configuration_(new AccelerometerReader::Configuration()),
- weak_factory_(this) {
-}
-
-AccelerometerReader::~AccelerometerReader() {
+// static
+AccelerometerReader* AccelerometerReader::GetInstance() {
+ return Singleton<AccelerometerReader,
+ LeakySingletonTraits<AccelerometerReader>>::get();
oshima 2015/01/07 16:39:57 why this needs to be leaky?
jonross 2015/01/12 15:15:46 As discussed offline this is not necessary. Thanks
}
void AccelerometerReader::Initialize(
@@ -212,6 +211,14 @@ void AccelerometerReader::RemoveObserver(Observer* observer) {
observers_.RemoveObserver(observer);
}
+AccelerometerReader::AccelerometerReader()
+ : configuration_(new AccelerometerReader::Configuration()),
+ weak_factory_(this) {
+}
+
+AccelerometerReader::~AccelerometerReader() {
+}
+
void AccelerometerReader::OnInitialized(
scoped_refptr<AccelerometerReader::Configuration> configuration,
bool success) {
« no previous file with comments | « chromeos/accelerometer/accelerometer_reader.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698