extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc - Issue 822453002: Introduce HostID and de-couple Extensions from "script injection System" [browser side]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc

Issue 822453002: Introduce HostID and de-couple Extensions from "script injection System" [browser side] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc

diff --git a/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc b/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc

index ae6f531bd6ca5b6e953fa4d0dec99196acd464a8..dcb0e6ebfd998ee40f1bd42f553e9685d3faa5f1 100644

--- a/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc

+++ b/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc

@@ -180,7 +180,8 @@ std::string WebRequestRulesRegistry::AddRulesImpl(

DCHECK(registered_rules.find(rule_id) == registered_rules.end());

scoped_ptr<WebRequestRule> webrequest_rule(WebRequestRule::Create(

- url_matcher_.condition_factory(), browser_context(), extension,

+ url_matcher_.condition_factory(), browser_context(),

+ HostID(HostID::EXTENSIONS, extension->id()), extension,

extension_installation_time, *rule,

base::Bind(&Checker, base::Unretained(extension)), &error));

if (!error.empty()) {

« no previous file with comments | « extensions/browser/api/declarative_webrequest/webrequest_action.cc ('k') | extensions/common/BUILD.gn » ('j') | no next file with comments »