extensions/browser/api/declarative_webrequest/webrequest_action.h - Issue 822453002: Introduce HostID and de-couple Extensions from "script injection System" [browser side]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_action.h

Issue 822453002: Introduce HostID and de-couple Extensions from "script injection System" [browser side] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/declarative/declarative_rule_unittest.cc ('k') | extensions/browser/api/declarative_webrequest/webrequest_action.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative_webrequest/webrequest_action.h

diff --git a/extensions/browser/api/declarative_webrequest/webrequest_action.h b/extensions/browser/api/declarative_webrequest/webrequest_action.h

index 03fc796e5700dd53c438473bda8c9c503b6b332c..fa01fd39f82f8b1cc21196406aed2dc1dcf5863f 100644

--- a/extensions/browser/api/declarative_webrequest/webrequest_action.h

+++ b/extensions/browser/api/declarative_webrequest/webrequest_action.h

@@ -135,6 +135,7 @@ class WebRequestAction : public base::RefCounted<WebRequestAction> {

// in case the input is syntactically unexpected.

static scoped_refptr<const WebRequestAction> Create(

content::BrowserContext* browser_context,

+ const HostID& host_id,

const Extension* extension,

const base::Value& json_action,

std::string* error,