chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc - Issue 822453002: Introduce HostID and de-couple Extensions from "script injection System" [browser side]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

Issue 822453002: Introduce HostID and de-couple Extensions from "script injection System" [browser side] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc ('k') | chrome/browser/extensions/convert_user_script.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

index e096f6d01227955a587a1b20d939f2fcedcb2a1c..6b19b8a385e5791a5ba2b3db70b640766688f6b6 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

@@ -712,7 +712,7 @@ TEST(WebRequestRulesRegistrySimpleTest, StageChecker) {

bool bad_message = false;

scoped_ptr<WebRequestActionSet> actions =

WebRequestActionSet::Create(

- NULL, NULL, rule.actions, &error, &bad_message);

+ NULL, HostID(), NULL, rule.actions, &error, &bad_message);

ASSERT_TRUE(error.empty()) << error;

ASSERT_FALSE(bad_message);

ASSERT_TRUE(actions);

@@ -739,7 +739,8 @@ TEST(WebRequestRulesRegistrySimpleTest, HostPermissionsChecker) {

std::string error;

bool bad_message = false;

scoped_ptr<WebRequestActionSet> action_set(

- WebRequestActionSet::Create(NULL, NULL, actions, &error, &bad_message));

+ WebRequestActionSet::Create(

+ NULL, HostID(), NULL, actions, &error, &bad_message));

ASSERT_TRUE(error.empty()) << error;

ASSERT_FALSE(bad_message);

ASSERT_TRUE(action_set);