chrome/browser/extensions/shared_user_script_master.cc - Issue 822453002: Introduce HostID and de-couple Extensions from "script injection System" [browser side]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/shared_user_script_master.cc

Issue 822453002: Introduce HostID and de-couple Extensions from "script injection System" [browser side] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Another round of comments of Devlin@. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_user_script_loader.h ('K') | « chrome/browser/extensions/shared_user_script_master.h ('k') | chrome/browser/extensions/user_script_loader.h » ('j') | chrome/browser/extensions/user_script_loader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/shared_user_script_master.cc

diff --git a/chrome/browser/extensions/shared_user_script_master.cc b/chrome/browser/extensions/shared_user_script_master.cc

index 803ba0682545651b5075591cd338f3a828795cc5..ad784c0e050ced3ff113a45203e0ff728b2513ce 100644

--- a/chrome/browser/extensions/shared_user_script_master.cc

+++ b/chrome/browser/extensions/shared_user_script_master.cc

@@ -8,12 +8,13 @@

#include "chrome/browser/profiles/profile.h"

#include "chrome/common/extensions/manifest_handlers/content_scripts_handler.h"

#include "extensions/browser/extension_registry.h"

+#include "extensions/common/consumer_id.h"

namespace extensions {

SharedUserScriptMaster::SharedUserScriptMaster(Profile* profile)

: loader_(profile,

- std::string() /* owner_extension_id */,

+ ConsumerID() /* consumer_id*/,

Devlin 2015/01/21 23:25:20 nit: probably don't need the annotation now (a str

Xi Han 2015/01/22 17:19:36 Removed.

true /* listen_for_extension_system_loaded */),

profile_(profile),

extension_registry_observer_(this) {