Introduce HostID and de-couple Extensions from "script injection System" [browser side]

chrome/browser/extensions/extension_user_script_loader.h

Index: chrome/browser/extensions/extension_user_script_loader.h
diff --git a/chrome/browser/extensions/extension_user_script_loader.h b/chrome/browser/extensions/extension_user_script_loader.h
new file mode 100644
index 0000000000000000000000000000000000000000..4cf02ca5e8c0f9f1334f8039be758f4c6f1ee811
--- /dev/null
+++ b/chrome/browser/extensions/extension_user_script_loader.h
@@ -0,0 +1,76 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.

[Devlin, 2015/01/14 16:45:09]

year

[Xi Han, 2015/01/14 23:46:03]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_USER_SCRIPT_LOADER_H_
+#define CHROME_BROWSER_EXTENSIONS_EXTENSION_USER_SCRIPT_LOADER_H_
+
+#include "base/memory/shared_memory.h"
+#include "chrome/browser/extensions/user_script_loader.h"
+#include "content/public/browser/notification_observer.h"
+#include "extensions/browser/extension_registry_observer.h"
+#include "extensions/common/extension.h"
+#include "extensions/common/extension_set.h"
+
+namespace content {
+class BrowserContext;
+}
+
+class Profile;
+
+namespace extensions {
+
+class ContentVerifier;
+class ExtensionRegistry;
+
+// UserScriptLoader for extensions.
+class ExtensionUserScriptLoader : public UserScriptLoader,
+                                  public ExtensionRegistryObserver {
+ public:
+  // The listen_for_extension_system_loaded is only set true when initilizing
+  // the Exttension System, e.g, when constructs SharedUserScriptMaster in
+  // ExtensionSystemImpl.
+  ExtensionUserScriptLoader(Profile* profile,
+                            const ConsumerID& consumer_id,
+                            bool listen_for_extension_system_loaded);
+  ~ExtensionUserScriptLoader() override;
+
+ private:
+  static bool LoadScriptContent(const ConsumerID& consumer_id,

[Devlin, 2015/01/14 16:45:09]

Can this go in an anonymous namespace in the .cc?

[Xi Han, 2015/01/14 23:46:03]

No, it can't. This static function is introduced for the purpose of creating "a
static virtual function". A pointer of this function is returned in a virtual
function LoadUserScriptsFunctionCallback GetLoadUserScriptsFunction() (see line
48). This is because we need a static function which will be called on file
thread, and we also want to keep different implementations for extensions (in
subclass) and without extensions (in the base class).

+                                UserScript::File* script_file,
+                                const SubstitutionMap* localization_messages,
+                                scoped_refptr<ContentVerifier> verifier);
+
+  // UserScriptLoader implementation.

[Devlin, 2015/01/14 16:45:09]

nit: prefer
// UserScriptLoader:

(goes for everywhere)

[Xi Han, 2015/01/14 23:46:03]

Done.

+  void UpdateConsumersInfo() override;
+  bool Ready() override;
+  ContentVerifier* GetContentVerifier() override;
+  LoadUserScriptsFunctionCallback GetLoadUserScriptsFunction() override;
+  void SendUpdate(content::RenderProcessHost* process,
+                  base::SharedMemoryHandle handle_for_process,
+                  const std::set<ConsumerID>& changed_consumers) override;
+
+  // ExtensionRegistryObserver implementation.
+  void OnExtensionUnloaded(content::BrowserContext* browser_context,
+                           const Extension* extension,
+                           UnloadedExtensionInfo::Reason reason) override;
+
+  // Initiates script load when we have been waiting for the extension system
+  // to be ready.
+  void OnExtensionSystemReady();
+
+  // If the extensions service has finished loading its initial set of
+  // extensions.
+  bool extension_system_ready_;
+
+  ScopedObserver<ExtensionRegistry, ExtensionRegistryObserver>
+      extension_registry_observer_;
+
+  base::WeakPtrFactory<ExtensionUserScriptLoader> weak_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(ExtensionUserScriptLoader);
+};
+
+}  // namespace extensions
+
+#endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_USER_SCRIPT_LOADER_H_