Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9615)

Unified Diff: chrome/browser/extensions/declarative_user_script_manager.cc

Issue 822453002: Introduce HostID and de-couple Extensions from "script injection System" [browser side] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix the test failures. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/declarative_user_script_manager.cc
diff --git a/chrome/browser/extensions/declarative_user_script_manager.cc b/chrome/browser/extensions/declarative_user_script_manager.cc
index e740b5b4f4e25c94889afcea7c8d1f92cecc1eb6..f8bcf5d87337407b41f648e3ca328d6751bfd3b5 100644
--- a/chrome/browser/extensions/declarative_user_script_manager.cc
+++ b/chrome/browser/extensions/declarative_user_script_manager.cc
@@ -4,7 +4,7 @@
#include "chrome/browser/extensions/declarative_user_script_manager.h"
-#include "chrome/browser/extensions/declarative_user_script_master.h"
+#include "chrome/browser/extensions/extension_declarative_user_script_master.h"
namespace extensions {
@@ -15,18 +15,32 @@ DeclarativeUserScriptManager::DeclarativeUserScriptManager(Profile* profile)
DeclarativeUserScriptManager::~DeclarativeUserScriptManager() {
}
-DeclarativeUserScriptMaster*
+linked_ptr<DeclarativeUserScriptMaster>
DeclarativeUserScriptManager::GetDeclarativeUserScriptMasterByID(
- const std::string& id) {
- UserScriptMasterMap::iterator it = declarative_user_script_masters_.find(id);
+ const ConsumerID& consumer_id) {
+ UserScriptMasterMap::iterator it =
+ declarative_user_script_masters_.find(consumer_id);
if (it != declarative_user_script_masters_.end())
- return it->second.get();
+ return it->second;
- linked_ptr<DeclarativeUserScriptMaster> master(
- new DeclarativeUserScriptMaster(profile_, id));
- declarative_user_script_masters_[id] = master;
- return master.get();
+ return CreateDeclarativeUserScriptMaster(consumer_id);
}
-} // extensions
+linked_ptr<DeclarativeUserScriptMaster>
+DeclarativeUserScriptManager::CreateDeclarativeUserScriptMaster(
+ const ConsumerID& consumer_id) {
+ linked_ptr<DeclarativeUserScriptMaster> master;
+ switch (consumer_id.host_type()) {
+ case ConsumerID::EXTENSIONS:
+ master.reset(
+ new ExtensionDeclarativeUserScriptMaster(profile_, consumer_id));
+ break;
+ default:
+ master.reset(new DeclarativeUserScriptMaster(profile_, consumer_id));
+ }
+ declarative_user_script_masters_[consumer_id] = master;
+ return master;
+}
+
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698