Introduce HostID and de-couple Extensions from "script injection System" [browser side]

extensions/common/user_script.h

Index: extensions/common/user_script.h
diff --git a/extensions/common/user_script.h b/extensions/common/user_script.h
index 5a2731536b2237699a1c76f54aa778d2af9643e8..fb0d2293d36cabcb7eaab4eafab680edb2d8f48b 100644
--- a/extensions/common/user_script.h
+++ b/extensions/common/user_script.h
@@ -10,7 +10,9 @@
 
 #include "base/basictypes.h"
 #include "base/files/file_path.h"
+#include "base/memory/linked_ptr.h"
 #include "base/strings/string_piece.h"
+#include "extensions/common/consumer.h"
 #include "extensions/common/url_pattern.h"
 #include "extensions/common/url_pattern_set.h"
 #include "url/gurl.h"
@@ -194,8 +196,12 @@ class UserScript {
   FileList& css_scripts() { return css_scripts_; }
   const FileList& css_scripts() const { return css_scripts_; }
 
-  const std::string& extension_id() const { return extension_id_; }
-  void set_extension_id(const std::string& id) { extension_id_ = id; }
+  const std::string& extension_id() const;

[Fady Samuel, 2015/01/07 19:19:40]

This is no longer a trivial accessor and so it must be renamed to GetExtensionID

[Xi Han, 2015/01/07 20:28:42]

Renamed.

+
+  ConsumerID* consumer_id() const { return consumer_id_.get(); }
+  void set_consumer_id(const ConsumerID& consumer_id) {
+    consumer_id_.reset(new ConsumerID(consumer_id));
+  }
 
   int id() const { return user_script_id_; }
   void set_id(int id) { user_script_id_ = id; }
@@ -203,7 +209,7 @@ class UserScript {
   bool is_incognito_enabled() const { return incognito_enabled_; }
   void set_incognito_enabled(bool enabled) { incognito_enabled_ = enabled; }
 
-  bool is_standalone() const { return extension_id_.empty(); }
+  bool is_standalone() const { return extension_id().empty(); }
 
   // Returns true if the script should be applied to the specified URL, false
   // otherwise.
@@ -222,6 +228,8 @@ class UserScript {
   // Pickle helper functions used to pickle the individual types of components.
   void PickleGlobs(::Pickle* pickle,
                    const std::vector<std::string>& globs) const;
+  void PickleConsumerID(::Pickle* pickle,
+                        linked_ptr<ConsumerID> consumer_id) const;
   void PickleURLPatternSet(::Pickle* pickle,
                            const URLPatternSet& pattern_list) const;
   void PickleScripts(::Pickle* pickle, const FileList& scripts) const;
@@ -229,6 +237,7 @@ class UserScript {
   // Unpickle helper functions used to unpickle individual types of components.
   void UnpickleGlobs(const ::Pickle& pickle, PickleIterator* iter,
                      std::vector<std::string>* globs);
+  ConsumerID* UnpickleConsumerID(const ::Pickle& pickle, PickleIterator* iter);
   void UnpickleURLPatternSet(const ::Pickle& pickle, PickleIterator* iter,
                              URLPatternSet* pattern_list);
   void UnpickleScripts(const ::Pickle& pickle, PickleIterator* iter,
@@ -267,9 +276,9 @@ class UserScript {
   // List of css scripts defined in content_scripts
   FileList css_scripts_;
 
-  // The ID of the extension this script is a part of, if any. Can be empty if
-  // the script is a "standlone" user script.
-  std::string extension_id_;
+  // The ID of the consumer this script is a part of. The host_id of the
+  // consumer_id can be empty if the script is a "standlone" user script.
+  linked_ptr<ConsumerID> consumer_id_;

[Fady Samuel, 2015/01/07 19:19:40]

Why is this a linked_ptr? Can it be a scoped_ptr?

[Xi Han, 2015/01/07 20:28:42]

No, it can't be a scoped_ptr, since scoped_ptr is not copyable. There are many
places that objects of UserScript be stored in STL containers, for example:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte....

 
   // The globally-unique id associated with this user script. Defaults to
   // -1 for invalid.