Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: chrome/common/extensions/manifest_handlers/content_scripts_handler.cc

Issue 822453002: Introduce HostID and de-couple Extensions from "script injection System" [browser side] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Another round of comments of Devlin@. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_handlers/content_scripts_handler.h" 5 #include "chrome/common/extensions/manifest_handlers/content_scripts_handler.h"
6 6
7 #include "base/files/file_util.h" 7 #include "base/files/file_util.h"
8 #include "base/lazy_instance.h" 8 #include "base/lazy_instance.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
11 #include "base/strings/string_util.h" 11 #include "base/strings/string_util.h"
12 #include "base/strings/utf_string_conversions.h" 12 #include "base/strings/utf_string_conversions.h"
13 #include "base/values.h" 13 #include "base/values.h"
14 #include "chrome/grit/generated_resources.h" 14 #include "chrome/grit/generated_resources.h"
15 #include "content/public/common/url_constants.h" 15 #include "content/public/common/url_constants.h"
16 #include "extensions/common/consumer_id.h"
16 #include "extensions/common/error_utils.h" 17 #include "extensions/common/error_utils.h"
17 #include "extensions/common/extension.h" 18 #include "extensions/common/extension.h"
18 #include "extensions/common/extension_resource.h" 19 #include "extensions/common/extension_resource.h"
19 #include "extensions/common/manifest_constants.h" 20 #include "extensions/common/manifest_constants.h"
20 #include "extensions/common/manifest_handlers/permissions_parser.h" 21 #include "extensions/common/manifest_handlers/permissions_parser.h"
21 #include "extensions/common/permissions/permissions_data.h" 22 #include "extensions/common/permissions/permissions_data.h"
22 #include "extensions/common/url_pattern.h" 23 #include "extensions/common/url_pattern.h"
23 #include "extensions/common/url_pattern_set.h" 24 #include "extensions/common/url_pattern_set.h"
24 #include "ui/base/l10n/l10n_util.h" 25 #include "ui/base/l10n/l10n_util.h"
25 #include "url/gurl.h" 26 #include "url/gurl.h"
(...skipping 386 matching lines...) Expand 10 before | Expand all | Expand 10 after
412 413
413 UserScript user_script; 414 UserScript user_script;
414 if (!LoadUserScriptFromDictionary(script_dict, 415 if (!LoadUserScriptFromDictionary(script_dict,
415 i, 416 i,
416 extension, 417 extension,
417 error, 418 error,
418 &user_script)) { 419 &user_script)) {
419 return false; // Failed to parse script context definition. 420 return false; // Failed to parse script context definition.
420 } 421 }
421 422
422 user_script.set_extension_id(extension->id()); 423 ConsumerID id(ConsumerID::EXTENSIONS, extension->id(), ConsumerID::TAB,
424 false /* is_declarative */);
425 user_script.set_consumer_id(id);
423 if (extension->converted_from_user_script()) { 426 if (extension->converted_from_user_script()) {
424 user_script.set_emulate_greasemonkey(true); 427 user_script.set_emulate_greasemonkey(true);
425 // Greasemonkey matches all frames. 428 // Greasemonkey matches all frames.
426 user_script.set_match_all_frames(true); 429 user_script.set_match_all_frames(true);
427 } 430 }
428 user_script.set_id(UserScript::GenerateUserScriptID()); 431 user_script.set_id(UserScript::GenerateUserScriptID());
429 content_scripts_info->content_scripts.push_back(user_script); 432 content_scripts_info->content_scripts.push_back(user_script);
430 } 433 }
431 extension->SetManifestData(keys::kContentScripts, 434 extension->SetManifestData(keys::kContentScripts,
432 content_scripts_info.release()); 435 content_scripts_info.release());
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
472 if (!IsScriptValid(path, css_script.relative_path(), 475 if (!IsScriptValid(path, css_script.relative_path(),
473 IDS_EXTENSION_LOAD_CSS_FAILED, error)) 476 IDS_EXTENSION_LOAD_CSS_FAILED, error))
474 return false; 477 return false;
475 } 478 }
476 } 479 }
477 480
478 return true; 481 return true;
479 } 482 }
480 483
481 } // namespace extensions 484 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698