Introduce HostID and de-couple Extensions from "script injection System" [browser side]

chrome/browser/extensions/api/declarative_content/content_action.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_CONTENT_CONTENT_ACTION_H_
 #define CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_CONTENT_CONTENT_ACTION_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 77 matching lines @@
  protected:
   friend class base::RefCounted<ContentAction>;
   virtual ~ContentAction();
 };
 
 // Action that injects a content script.
 class RequestContentScript : public ContentAction {
  public:
   struct ScriptData;
 
+  // TODO(hanxi): add RulesRegistryID to the RequestKey.
+  struct RequestKey {

[Devlin, 2015/01/20 17:51:05]

Could we instead just use a std::string for this?

[Xi Han, 2015/01/21 21:30:16]

Ok, I will change it to std::string, and change it when we need to include more
information for <webview>.

+    explicit RequestKey(const std::string& host_id) : host_id(host_id) {}
+    bool operator<(const RequestKey& key) const {
+      return host_id.compare(key.host_id) < 0;
+    }
+    std::string host_id;
+  };
+
   RequestContentScript(content::BrowserContext* browser_context,
                        const Extension* extension,
                        const ScriptData& script_data);
   RequestContentScript(DeclarativeUserScriptMaster* master,
                        const Extension* extension,
                        const ScriptData& script_data);
 
   static scoped_refptr<ContentAction> Create(
       content::BrowserContext* browser_context,
       const Extension* extension,
@@ skipping 35 matching lines @@
     DCHECK(master_);
     master_->AddScript(script_);
   }
 
   ~RequestContentScript() override;
 
   void InstructRenderProcessToInject(content::WebContents* contents,
                                      const std::string& extension_id) const;
 
   UserScript script_;
+  // The lifetime of the master_ is managed by DeclarativeUserScriptManager,

[Devlin, 2015/01/20 17:51:05]

nit: newline before this.
nit: Document why the lifetime is safe (i.e., show that the
DeclarativeUserScriptManager outlives the RequestContentScript).

[Xi Han, 2015/01/21 21:30:16]

Lifetime is hard to explain, so I try my best to add some comments here. Feel
free to update if you think they are not enough to explain. Thanks.

+  // which manages a map of master objects.
   DeclarativeUserScriptMaster* master_;
 
   DISALLOW_COPY_AND_ASSIGN(RequestContentScript);
 };
 
 typedef DeclarativeActionSet<ContentAction> ContentActionSet;
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_DECLARATIVE_CONTENT_CONTENT_ACTION_H_