Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 822433003: Collect more information when failing to allocate a SharedBitmap on win (Closed)

Created:
6 years ago by jbauman
Modified:
6 years ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Collect more information when failing to allocate a SharedBitmap on win Gather information about the bitmap size, how much virtual memory is used, etc., and ensure it's in the minidump. This might help up narrow down the causes of being unable to allocate more shared memory. BUG=429763 Committed: https://crrev.com/8b0b42dd0b834407235dac9ec21166ee86b8d6b1 Cr-Commit-Position: refs/heads/master@{#309329}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M content/child/child_shared_bitmap_manager.cc View 1 3 chunks +39 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jbauman
6 years ago (2014-12-19 23:41:18 UTC) #2
piman
lgtm https://codereview.chromium.org/822433003/diff/1/content/child/child_shared_bitmap_manager.cc File content/child/child_shared_bitmap_manager.cc (right): https://codereview.chromium.org/822433003/diff/1/content/child/child_shared_bitmap_manager.cc#newcode123 content/child/child_shared_bitmap_manager.cc:123: if (!memory) nit: memory is !null here, so ...
6 years ago (2014-12-20 02:40:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/822433003/20001
6 years ago (2014-12-20 02:44:25 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-20 03:36:01 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-20 03:36:57 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8b0b42dd0b834407235dac9ec21166ee86b8d6b1
Cr-Commit-Position: refs/heads/master@{#309329}

Powered by Google App Engine
This is Rietveld 408576698