Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager.cc

Issue 8223019: Remove unnecessary LOG(WARNING). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/input_method/input_method_manager.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_manager.cc b/chrome/browser/chromeos/input_method/input_method_manager.cc
index 7f404ea535cb687206194267a33162f88c47f9bb..381d00347c549fd0ff8ff6a84bbff448e7ba0390 100644
--- a/chrome/browser/chromeos/input_method/input_method_manager.cc
+++ b/chrome/browser/chromeos/input_method/input_method_manager.cc
@@ -23,7 +23,6 @@
#include "chrome/browser/chromeos/input_method/virtual_keyboard_selector.h"
#include "chrome/browser/chromeos/input_method/xkeyboard.h"
#include "chrome/browser/chromeos/language_preferences.h"
-#include "chrome/browser/chromeos/system/runtime_environment.h"
#include "content/browser/browser_thread.h"
#include "content/common/notification_observer.h"
#include "content/common/notification_registrar.h"
@@ -244,9 +243,8 @@ class InputMethodManagerImpl : public HotkeyManager::Observer,
// Initially active_input_method_ids_ is empty. In this case, just
// returns the fallback input method descriptor.
if (result->empty()) {
- if (system::runtime_environment::IsRunningOnChromeOS()) {
- LOG(WARNING) << "No active input methods found.";
- }
+ // Since browser_tests call neither SetImeConfig("preload_engines") nor
+ // EnableInputMethod(), this path might be taken.
result->push_back(
InputMethodDescriptor::GetFallbackInputMethodDescriptor());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698