Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 82223002: Update VDA golden checksum values for EVDA (Closed)

Created:
7 years, 1 month ago by sheu
Modified:
7 years, 1 month ago
Reviewers:
sabercrombie1, piman
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org, Pawel Osciak, wuchengli
Visibility:
Public.

Description

Update VDA golden checksum values for EVDA This CL fixes the checksum values to match that generated by the EVDA after r235128, which are more correct than before (does not drop last frames). Also: add support for comments in md5 checksum files for VDA unittest, and use comments to label golden checksum values by platform. BUG=321547 TEST=local build, run on CrOS snow Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236868

Patch Set 1 : 945cf11f Initial. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/gpu/testdata/bear.h264.md5 View 1 chunk +5 lines, -1 line 0 comments Download
M content/common/gpu/testdata/npot-video.h264.md5 View 1 chunk +5 lines, -1 line 0 comments Download
M content/common/gpu/testdata/red-green.h264.md5 View 1 chunk +5 lines, -1 line 0 comments Download
M content/common/gpu/testdata/test-25fps.h264.md5 View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sheu
sabercrombie@: PTAL Adding more folks who might be interested.
7 years, 1 month ago (2013-11-22 00:15:21 UTC) #1
sabercrombie1
lgtm
7 years, 1 month ago (2013-11-22 01:14:21 UTC) #2
sheu
piman@: just OWNERs checkoff. Should be simple.
7 years, 1 month ago (2013-11-22 01:16:11 UTC) #3
piman
lgtm
7 years, 1 month ago (2013-11-22 20:15:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/82223002/10001
7 years, 1 month ago (2013-11-22 20:58:54 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-22 23:26:57 UTC) #6
Message was sent while issue was closed.
Change committed as 236868

Powered by Google App Engine
This is Rietveld 408576698