Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/components.gyp

Issue 822133003: Refactor webview to use //components/printing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/renderer/chrome_content_renderer_client.cc ('K') | « chrome/renderer/chrome_content_renderer_client.cc ('k') | components/printing/renderer/print_web_view_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/components.gyp
diff --git a/components/components.gyp b/components/components.gyp
index 0972d45d32689cb2f08ab1e65499981a496fb050..b6902294b8ef6908c7873bf7d6fa5f328e475755 100644
--- a/components/components.gyp
+++ b/components/components.gyp
@@ -140,10 +140,8 @@
'webdata_services.gypi',
],
}],
- ['android_webview_build == 0 and OS != "ios"', {
+ ['enable_basic_printing==1 or enable_print_preview==1', {
'includes': [
- # TODO(dgn) move it to a condition based on whether print is enabled
- # once the duplicates have been removed from webview.
'printing.gypi',
],
}],
« chrome/renderer/chrome_content_renderer_client.cc ('K') | « chrome/renderer/chrome_content_renderer_client.cc ('k') | components/printing/renderer/print_web_view_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698