android_webview/renderer/aw_content_renderer_client.cc - Issue 822133003: Refactor webview to use //components/printing

Unified Diff: android_webview/renderer/aw_content_renderer_client.cc

Issue 822133003: Refactor webview to use //components/printing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/renderer/aw_content_renderer_client.cc

diff --git a/android_webview/renderer/aw_content_renderer_client.cc b/android_webview/renderer/aw_content_renderer_client.cc

index 24349cdd9a00387da9f84c3362e15d73c2aa419a..198326ffef012f0edc773862896d184af1426a7a 100644

--- a/android_webview/renderer/aw_content_renderer_client.cc

+++ b/android_webview/renderer/aw_content_renderer_client.cc

@@ -9,14 +9,15 @@

#include "android_webview/common/url_constants.h"

#include "android_webview/renderer/aw_key_systems.h"

#include "android_webview/renderer/aw_permission_client.h"

+#include "android_webview/renderer/aw_print_web_view_helper_delegate.h"

#include "android_webview/renderer/aw_render_frame_ext.h"

#include "android_webview/renderer/aw_render_view_ext.h"

#include "android_webview/renderer/print_render_frame_observer.h"

-#include "android_webview/renderer/print_web_view_helper.h"

#include "base/message_loop/message_loop.h"

#include "base/strings/utf_string_conversions.h"

#include "components/autofill/content/renderer/autofill_agent.h"

#include "components/autofill/content/renderer/password_autofill_agent.h"

+#include "components/printing/renderer/print_web_view_helper.h"

#include "components/visitedlink/renderer/visitedlink_slave.h"

#include "content/public/common/url_constants.h"

#include "content/public/renderer/document_state.h"

@@ -145,7 +146,13 @@ void AwContentRendererClient::RenderViewCreated(

content::RenderView* render_view) {

AwRenderViewExt::RenderViewCreated(render_view);

- new printing::PrintWebViewHelper(render_view);

+ new printing::PrintWebViewHelper(

+ render_view,

+ false /* out_of_process_pdf_enabled */,

sgurun-gerrit only 2015/01/16 21:22:04 it is nice that you commented each bool parameter!

+ true /* print_preview_disabled */,

+ false /* should_ask_print_settings */,

+ scoped_ptr<printing::PrintWebViewHelper::Delegate>(

+ new AwPrintWebViewHelperDelegate()));

sgurun-gerrit only 2015/01/16 21:22:04 who should own AwPrintWebViewHelperDelegate() and

dgn 2015/01/19 17:48:08 The one linked below says it's not needed on tempo

sgurun-gerrit only 2015/01/19 18:21:35 yep, scratch this.

}

bool AwContentRendererClient::HasErrorPage(int http_status_code,