components/components.gyp - Issue 822133003: Refactor webview to use //components/printing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/components.gyp

Issue 822133003: Refactor webview to use //components/printing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/components.gyp

diff --git a/components/components.gyp b/components/components.gyp

index c6619c62dedde227fa636a97176f5763c848a181..a00c4e0bc10ae087aa167b38d6feb1266b03e161 100644

--- a/components/components.gyp

+++ b/components/components.gyp

@@ -139,10 +139,8 @@

'webdata_services.gypi',

}],

- ['android_webview_build == 0 and OS != "ios"', {

+ ['OS != "ios" and (enable_basic_printing==1 or enable_print_preview==1)', {

Vitaly Buka (NO REVIEWS) 2015/01/08 22:54:27 Isn't (enable_basic_printing==0 and enable_print_p

dgn 2015/01/16 10:26:43 Done.

'includes': [

- # TODO(dgn) move it to a condition based on whether print is enabled

- # once the duplicates have been removed from webview.

'printing.gypi',

}],