android_webview/renderer/aw_print_web_view_helper_delegate.cc - Issue 822133003: Refactor webview to use //components/printing

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/renderer/aw_print_web_view_helper_delegate.cc

Issue 822133003: Refactor webview to use //components/printing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« android_webview/renderer/aw_print_web_view_helper_delegate.h ('K') | « android_webview/renderer/aw_print_web_view_helper_delegate.h ('k') | android_webview/renderer/print_render_frame_observer.cc » ('j') | android_webview/renderer/print_web_view_helper.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "android_webview/renderer/aw_print_web_view_helper_delegate.h"

	6

	7 #include "content/public/renderer/render_view.h"

	8 #include "third_party/WebKit/public/web/WebElement.h"

	9 #include "third_party/WebKit/public/web/WebLocalFrame.h"
	sgurun-gerrit only 2015/01/16 21:22:04 I don't think you need to include this, just a for I don't think you need to include this, just a forward class would be sufficient? Bernhard Bauer 2015/01/19 10:05:25 Not even that is necessary; WebLocalFrame is alrea Show quoted text On 2015/01/16 21:22:04, sgurun wrote: > I don't think you need to include this, just a forward class would be > sufficient? Not even that is necessary; WebLocalFrame is already used in the header, so it has to be already forward-declared :) Same for render_view.h above. dgn 2015/01/23 15:21:09 Done. Show quoted text On 2015/01/19 10:05:25, Bernhard Bauer wrote: > On 2015/01/16 21:22:04, sgurun wrote: > > I don't think you need to include this, just a forward class would be > > sufficient? > > Not even that is necessary; WebLocalFrame is already used in the header, so it > has to be already forward-declared :) > > Same for render_view.h above. Done.
	10
	sgurun-gerrit only 2015/01/16 21:22:04 scope to android_webview namespace scope to android_webview namespace dgn 2015/01/23 15:21:09 Done. Show quoted text On 2015/01/16 21:22:04, sgurun wrote: > scope to android_webview namespace Done.
	11 AwPrintWebViewHelperDelegate::~AwPrintWebViewHelperDelegate(){

	12 }

	13

	14 bool AwPrintWebViewHelperDelegate::CancelPrerender(

	15 content::RenderView* render_view, int routing_id) {

	16 return false;

	17 }

	18

	19 blink::WebElement AwPrintWebViewHelperDelegate::GetPdfElement(

	20 blink::WebLocalFrame* frame) {

	21 return blink::WebElement();

	22 }

OLD	NEW