android_webview/common/android_webview_message_generator.h - Issue 822133003: Refactor webview to use //components/printing

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/common/android_webview_message_generator.h

Issue 822133003: Refactor webview to use //components/printing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« android_webview/DEPS ('K') | « android_webview/browser/renderer_host/print_manager.cc ('k') | android_webview/common/print_messages.h » ('j') | android_webview/renderer/aw_content_renderer_client.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Multiply-included file, hence no include guard.	5 // Multiply-included file, hence no include guard.

6	6

7 #include "android_webview/common/print_messages.h"

8 #include "android_webview/common/render_view_messages.h"	7 #include "android_webview/common/render_view_messages.h"

	8 #include "components/printing/common/print_messages.h"
	sgurun-gerrit only 2015/01/16 21:22:04 this seems weird. I think just like autofill or pd this seems weird. I think just like autofill or pdf, you should create message generators in components, next to the messages.h https://code.google.com/p/chromium/codesearch#chromium/src/components/pdf/com... https://code.google.com/p/chromium/codesearch#chromium/src/components/autofil... dgn 2015/01/19 17:48:08 Uploaded https://codereview.chromium.org/857053002 Show quoted text On 2015/01/16 at 21:22:04, sgurun wrote: > this seems weird. I think just like autofill or pdf, you should create message generators in components, next to the messages.h > > https://code.google.com/p/chromium/codesearch#chromium/src/components/pdf/com... > https://code.google.com/p/chromium/codesearch#chromium/src/components/autofil... Uploaded https://codereview.chromium.org/857053002
OLD	NEW