android_webview/DEPS - Issue 822133003: Refactor webview to use //components/printing

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/DEPS

Issue 822133003: Refactor webview to use //components/printing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Please include benm@ and (erikwright@) on the review for any changes	1 # Please include benm@ and (erikwright@) on the review for any changes

2 # to DEPS files under android_webview/	2 # to DEPS files under android_webview/

3	3

4 # Do not add any includes under chrome/ anywhere in android_webview.	4 # Do not add any includes under chrome/ anywhere in android_webview.

5	5

6 include_rules = [	6 include_rules = [

7 # lib is the top-level target, and must remain a leaf in the dependency tree.	7 # lib is the top-level target, and must remain a leaf in the dependency tree.

8 "-android_webview/lib",	8 "-android_webview/lib",

9	9

10 "+components/data_reduction_proxy",	10 "+components/data_reduction_proxy",

	11 "+components/printing/common",
	sgurun-gerrit only 2015/01/16 21:22:04 is there a reason we cannot move the DEPS change t is there a reason we cannot move the DEPS change to android_webview/common/DEPS? dgn 2015/01/19 17:48:08 Will do. It will also have to be added to browser' Show quoted text On 2015/01/16 at 21:22:04, sgurun wrote: > is there a reason we cannot move the DEPS change to android_webview/common/DEPS? Will do. It will also have to be added to browser's deps dgn 2015/01/23 15:21:09 Done. Show quoted text On 2015/01/19 17:48:08, dgn wrote: > On 2015/01/16 at 21:22:04, sgurun wrote: > > is there a reason we cannot move the DEPS change to > android_webview/common/DEPS? > > Will do. It will also have to be added to browser's deps Done.
11 "+content/browser/media/android",	12 "+content/browser/media/android",

12 "+content/public/common",	13 "+content/public/common",

13 "+crypto",	14 "+crypto",

14 "+gpu",	15 "+gpu",

15 "+jni",	16 "+jni",

16 "+net",	17 "+net",

17 "+skia",	18 "+skia",

18 "+third_party/skia/include",	19 "+third_party/skia/include",

19 "+ui/android",	20 "+ui/android",

20 "+ui/base",	21 "+ui/base",

21 "+ui/gfx",	22 "+ui/gfx",

22 "+webkit/common/gpu"	23 "+webkit/common/gpu"

23 ]	24 ]

OLD	NEW

« no previous file with comments | « no previous file | android_webview/android_webview.gyp » ('j') | android_webview/common/android_webview_message_generator.h » ('J')