Made gsutil.py truly transparent

Made gsutil.py truly transparent

The previous version was modifying gsutil output by adding a
stacktrace upon non-zero return code, which broke existing code.

BUG=400871
R=hinoka@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293501

[pgervais, 2014-12-23 23:14:00]

pgervais@chromium.org changed reviewers:
+ hinoka@chromium.org

[pgervais, 2014-12-23 23:14:00]

ptal

test: ran it and checked it was actually calling gsutil and returning correct
results.

[hinoka, 2014-12-23 23:22:11]

lgtm

email troopers as an fyi before landing pl0x

[pgervais, 2014-12-23 23:29:23]

The CQ bit was checked by pgervais@chromium.org

[commit-bot: I haz the power, 2014-12-23 23:29:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/822093002/1

[commit-bot: I haz the power, 2014-12-23 23:32:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-23 23:32:51]

Presubmit check for 822093002-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Pylint (113 files) (129.88s) failed
************* Module android
W: 12, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module blink
W: 13, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)
************* Module ios
W: 12, 0: Method 'expected_root' is abstract in class 'Recipe' but is not
overridden (abstract-method)


tests/git_common_test.py (6.57s) failed
...F..................u.......
======================================================================
FAIL: testGetBranchesInfo (__main__.GitMutableFunctionsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_common_test.py", line 418, in testGetBranchesInfo
    self.assertEquals(expected, actual)
AssertionError: {'': None, 'happybranch': ('90f0504', 'master', 1, None),
'parent_gone': ('d3cb6 [truncated]... != {'': None, 'happybranch':
BranchesInfo(hash='90f0504', upstream='master', ahead= [truncated]...
  {'': None,
-  'child': ('90f0504', 'happybranch', None, None),
-  'happybranch': ('90f0504', 'master', 1, None),
-  'master': ('d3cb652', '', None, None),
-  'parent_gone': ('d3cb652', 'to_delete', 1, None),
+  'child': BranchesInfo(hash='90f0504', upstream='happybranch', ahead=None,
behind=None),
+  'happybranch': BranchesInfo(hash='90f0504', upstream='master', ahead=1,
behind=None),
+  'master': BranchesInfo(hash='d3cb652', upstream='', ahead=None, behind=None),
+  'parent_gone': BranchesInfo(hash='d3cb652', upstream='to_delete',
ahead=35063072, behind=170),
   'to_delete': None}

----------------------------------------------------------------------
Ran 30 tests in 6.344s

FAILED (failures=1, unexpected successes=1)
Name         Stmts   Miss  Cover   Missing
------------------------------------------
git_common     373      0   100%   


Presubmit checks took 175.5s to calculate.

[pgervais, 2014-12-23 23:40:31]

Committed patchset #1 (id:1) manually as 293501.