LayoutTests/crypto/subtle/hkdf-deriveBits.html - Issue 822083003: Webcrypto: add layout tests for HKDF algorithm

Side by Side Diff: LayoutTests/crypto/subtle/hkdf-deriveBits.html

Issue 822083003: Webcrypto: add layout tests for HKDF algorithm (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/crypto/subtle/derive-hkdf-keys.html ('K') | « LayoutTests/crypto/subtle/derive-hkdf-keys-expected.txt ('k') | LayoutTests/crypto/subtle/hkdf-deriveBits-expected.txt » ('j') | LayoutTests/crypto/subtle/hkdf-deriveBits-failures.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 <script src="resources/common.js"></script>

	6 </head>

	7 <body>

	8 <p id="description"></p>

	9 <div id="console"></div>

	10

	11 <script>

	12 description("Test that HKDF does not support methods it should not support.");

	13

	14 jsTestIsAsync = true;

	15

	16 kHkdfKey = "0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b";

	17

	18 kHkdfAlgorithm = {

	19 name: "HKDF",

	20 hash: "SHA-256",

	21 salt: new Uint8Array(),

	22 info: new Uint8Array()

	23 };

	24

	25 var extractable = true;

	26 Promise.resolve(null).then(function(result) {

	27 // Set up the test by creating an HKDF key.

	28 return crypto.subtle.importKey("raw", hexStringToUint8Array(kHkdfKey), {name : "HKDF"}, extractable, ['deriveKey', 'deriveBits']);

	29 }).then(function(result) {

	30 baseKey = result;

	31

	32 debug("Derive 0 bits from the HKDF key");

	33 return crypto.subtle.deriveBits(kHkdfAlgorithm, baseKey, 0);

	34 }).then(function(result) {

	35 derivedBits = result;

	36

	37 shouldBe("derivedBits.byteLength", "0");

	38

	39 debug("Derive 4 bits from the HKDF key");

	40 return crypto.subtle.deriveBits(kHkdfAlgorithm, baseKey, 4);

	41 }).then(function(result) {

	42 derivedBits = new DataView(result);

	43

	44 shouldBe("derivedBits.byteLength", "1");

	45 shouldBe("derivedBits.getUint8(0) % 16", "0");
	eroman 2015/01/13 00:45:34 My earlier comment is unresolved. Why not test the My earlier comment is unresolved. Why not test the exact value rather than just the last 4 bits? for instance: shouldBe("derivedBits.getUint8(0)", 0xE0); (0xE0 just placeholder for what actual value is supposed to be). nharper 2015/01/13 01:43:26 My thought was "test that the last 4 bits are zero Show quoted text On 2015/01/13 00:45:34, eroman wrote: > My earlier comment is unresolved. Why not test the exact value rather than just > the last 4 bits? > > for instance: > > shouldBe("derivedBits.getUint8(0)", 0xE0); > > (0xE0 just placeholder for what actual value is supposed to be). My thought was "test that the last 4 bits are zeroes", which is why it was that way. I've changed it to test the exact value and added a comment about checking the last bits. eroman 2015/01/14 02:45:11 The reason I want to test the whole byte, is this Show quoted text On 2015/01/13 01:43:26, nharper wrote: > On 2015/01/13 00:45:34, eroman wrote: > > My earlier comment is unresolved. Why not test the exact value rather than > just > > the last 4 bits? > > > > for instance: > > > > shouldBe("derivedBits.getUint8(0)", 0xE0); > > > > (0xE0 just placeholder for what actual value is supposed to be). > > My thought was "test that the last 4 bits are zeroes", which is why it was that > way. I've changed it to test the exact value and added a comment about checking > the last bits. The reason I want to test the whole byte, is this is the only test you have which is checking deriving bits that is not a multiple of 8 (well other than the max value one). What if the truncation was implemented by simply zeroing the entire byte? So it is worth checking that only the last 4 bits are zero, and the rest correspond with the expected byte value. nharper 2015/01/14 02:53:42 Ok, that makes sense. Show quoted text On 2015/01/14 02:45:11, eroman wrote: > On 2015/01/13 01:43:26, nharper wrote: > > On 2015/01/13 00:45:34, eroman wrote: > > > My earlier comment is unresolved. Why not test the exact value rather than > > just > > > the last 4 bits? > > > > > > for instance: > > > > > > shouldBe("derivedBits.getUint8(0)", 0xE0); > > > > > > (0xE0 just placeholder for what actual value is supposed to be). > > > > My thought was "test that the last 4 bits are zeroes", which is why it was > that > > way. I've changed it to test the exact value and added a comment about > checking > > the last bits. > > The reason I want to test the whole byte, is this is the only test you have > which is checking deriving bits that is not a multiple of 8 (well other than the > max value one). > > What if the truncation was implemented by simply zeroing the entire byte? So it > is worth checking that only the last 4 bits are zero, and the rest correspond > with the expected byte value. Ok, that makes sense.
	46

	47 }).then(finishJSTest, failAndFinishJSTest);

	48

	49 </script>

	50

	51 </body>

	52 </html>

OLD	NEW