LayoutTests/crypto/subtle/derive-hkdf-keys.html - Issue 822083003: Webcrypto: add layout tests for HKDF algorithm

Side by Side Diff: LayoutTests/crypto/subtle/derive-hkdf-keys.html

Issue 822083003: Webcrypto: add layout tests for HKDF algorithm (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/crypto/subtle/clone-hmacKey.html ('k') | LayoutTests/crypto/subtle/derive-hkdf-keys-expected.txt » ('j') | LayoutTests/crypto/subtle/hkdf-deriveBits.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 <script src="resources/common.js"></script>

	6 </head>

	7 <body>

	8 <p id="description"></p>

	9 <div id="console"></div>

	10

	11 <script>

	12 description("Test deriving HKDF keys with deriveKey()");

	13

	14 jsTestIsAsync = true;

	15

	16 var extractable = true;

	17 var derivingKeyAlgorithm = {

	18 name: "HKDF",

	19 hash: "SHA-256",

	20 salt: new Uint8Array(),

	21 info: new Uint8Array()

	22 };

	23

	24 Promise.resolve(null).then(function(result) {

	25 return crypto.subtle.generateKey({name: "ECDH", namedCurve: "P-256"}, true, ['deriveKey']);

	26 }).then(function(result) {

	27 ecdhKey = result;

	28

	29 return crypto.subtle.generateKey({name: "ECDH", namedCurve: "P-256"}, false, ['deriveKey']);

	30 }).then(function(result) {

	31 publicKey = result.publicKey;

	32

	33 debug("Derive an HKDF key from ECDH keys");

	34 return crypto.subtle.deriveKey({name: "ECDH", namedCurve: "P-256", public: p ublicKey}, ecdhKey.privateKey, "HKDF", true, ['deriveBits']);

	35 }).then(function(result) {

	36 hkdfKey = result;

	37

	38 shouldEvaluateAs("hkdfKey.algorithm.name", "HKDF");

	39 shouldEvaluateAs("hkdfKey.extractable", true);

	40 shouldEvaluateAs("hkdfKey.usages.join(',')", "deriveBits");

	41

	42 debug("\nTry to derive an HKDF key from an HKDF key");

	43 var hkdfAlgorithm = {

	44 name: "HKDF",

	45 hash: "SHA-256",

	46 salt: new Uint8Array(),

	47 info: new Uint8Array()

	48 };

	49 return crypto.subtle.deriveKey(hkdfAlgorithm, hkdfKey, "HKDF", true, ['deriv eBits']);
	eroman 2015/01/12 22:35:23 This test is a weak test IMO: (1) using an impor This test is a weak test IMO: (1) using an imported ECDH keys rather than generated one would allow verifying the final HKDF key in a more meaningful way (either by structured cloning it or by using it in a derive bits operation) (2) this deriveKey() is not the interesting case. The more interesting case would be if hkdfKey had the 'deriveKey' usages. As it is, this fails because of a usages violation. We should have a test (either in addition to or in place of) which tests the get key length mismatch. nharper 2015/01/13 00:11:15 1) I'm now importing 2 ECDH keys and deriving an H Show quoted text On 2015/01/12 22:35:23, eroman wrote: > This test is a weak test IMO: > (1) using an imported ECDH keys rather than generated one would allow > verifying the final HKDF key in a more meaningful way (either by structured > cloning it or by using it in a derive bits operation) > > (2) this deriveKey() is not the interesting case. The more interesting case > would be if hkdfKey had the 'deriveKey' usages. As it is, this fails because of > a usages violation. We should have a test (either in addition to or in place of) > which tests the get key length mismatch. 1) I'm now importing 2 ECDH keys and deriving an HKDF key from that. I then create another HKDF key from the ECDH secret (pre-computed), and on both HKDF keys call deriveBits and verify that they derive the same bits. This is a test that calling deriveKey with an ECDH key and a derived key type of HKDF will result in importing the correct material into the HKDF key - it doesn't check that HKDF is implemented correctly (that's tested by the test vectors test). 2) I changed the usage from deriveBits to deriveKey to test what I meant to test. I noticed that the test case of derive HKDF key from HKDF key is both in this file and hkdf-deriveKey.html - do you have a preference for which one it lives in? eroman 2015/01/13 00:45:34 Either location is fine as long as there is one so Show quoted text On 2015/01/13 00:11:15, nharper wrote: > On 2015/01/12 22:35:23, eroman wrote: > > This test is a weak test IMO: > > (1) using an imported ECDH keys rather than generated one would allow > > verifying the final HKDF key in a more meaningful way (either by structured > > cloning it or by using it in a derive bits operation) > > > > (2) this deriveKey() is not the interesting case. The more interesting case > > would be if hkdfKey had the 'deriveKey' usages. As it is, this fails because > of > > a usages violation. We should have a test (either in addition to or in place > of) > > which tests the get key length mismatch. > > 1) I'm now importing 2 ECDH keys and deriving an HKDF key from that. I then > create another HKDF key from the ECDH secret (pre-computed), and on both HKDF > keys call deriveBits and verify that they derive the same bits. This is a test > that calling deriveKey with an ECDH key and a derived key type of HKDF will > result in importing the correct material into the HKDF key - it doesn't check > that HKDF is implemented correctly (that's tested by the test vectors test). > > 2) I changed the usage from deriveBits to deriveKey to test what I meant to > test. I noticed that the test case of derive HKDF key from HKDF key is both in > this file and hkdf-deriveKey.html - do you have a preference for which one it > lives in? Either location is fine as long as there is one source of truth. How about keeping it in hkdf-derivekey ?
	50 }).then(failAndFinishJSTest, function(result) {

	51 logError(result);

	52 }).then(finishJSTest, failAndFinishJSTest);

	53

	54 </script>

	55

	56 </body>

	57 </html>

OLD	NEW