LayoutTests/crypto/subtle/hkdf-failures.html - Issue 822083003: Webcrypto: add layout tests for HKDF algorithm

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/crypto/subtle/hkdf-failures.html

Issue 822083003: Webcrypto: add layout tests for HKDF algorithm (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: use correct diffbase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/crypto/subtle/hkdf-deriveKey.html ('K') | « LayoutTests/crypto/subtle/hkdf-deriveKey-expected.txt ('k') | LayoutTests/crypto/subtle/hkdf-failures-expected.txt » ('j') | LayoutTests/crypto/subtle/hkdf-failures-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 <script src="resources/common.js"></script>

	6 </head>

	7 <body>

	8 <p id="description"></p>

	9 <div id="console"></div>

	10

	11 <script>

	12 description("Test that HKDF does not support methods it should not support.");

	13

	14 jsTestIsAsync = true;

	15

	16 kHkdfKey = "0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b0b";

	17

	18 var extractable = true;

	19 Promise.resolve(null).then(function(result) {

	20 // set up the test by creating an HKDF key and an RSA key
	eroman 2015/01/07 01:18:43 indent by 4. indent by 4. nharper 2015/01/09 22:41:47 Done. Show quoted text On 2015/01/07 01:18:43, eroman wrote: > indent by 4. Done.
	21 return crypto.subtle.importKey("raw", hexStringToUint8Array(kHkdfKey), {name: "HKDF"}, extractable, ['deriveKey', 'deriveBits']);

	22 }).then(function(result) {

	23 hkdfKey = result;

	24

	25 debug("\nHKDF does not support exportKey()...");
	eroman 2015/01/07 01:18:43 Let's sync up with Ryan when he gets back and see Let's sync up with Ryan when he gets back and see what he thinks of the spec bug. (I think we should be supporting exportKey()). eroman 2015/01/09 03:16:01 I chatted with Ryan and this is fine as is. My co Show quoted text On 2015/01/07 01:18:43, eroman wrote: > Let's sync up with Ryan when he gets back and see what he thinks of the spec > bug. (I think we should be supporting exportKey()). I chatted with Ryan and this is fine as is. My compatibility concern (preventing extractable=true) is going to be a non-issue. We can re-visit adding exportKey() if needed later, so full steam ahead on this issue!
	26 return crypto.subtle.exportKey("raw", hkdfKey);

	27 }).then(failAndFinishJSTest, function(result) {

	28 logError(result);

	29

	30 }).then(finishJSTest);

	31

	32 </script>

	33

	34 </body>

	35 </html>

OLD	NEW