LayoutTests/crypto/subtle/hkdf-failures-expected.txt - Issue 822083003: Webcrypto: add layout tests for HKDF algorithm

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/crypto/subtle/hkdf-failures-expected.txt

Issue 822083003: Webcrypto: add layout tests for HKDF algorithm (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: use correct diffbase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 Test that HKDF does not support methods it should not support.

	2

	3 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE ".

	4

	5

	6

	7 HKDF does not support exportKey()...
	eroman 2015/01/07 01:18:43 Make this read what it is about to do: calling Make this read what it is about to do: calling exportKey() for HKDF key... nharper 2015/01/09 22:41:47 Done. Show quoted text On 2015/01/07 01:18:43, eroman wrote: > Make this read what it is about to do: > calling exportKey() for HKDF key... Done.
	8 error is: NotSupportedError: Unsupported export key format for algorithm
	eroman 2015/01/07 01:18:43 This is an unexpected error message -- it should i This is an unexpected error message -- it should instead say the operation is unsupported if we are to go by the spec's interpretation. eroman 2015/01/09 03:16:01 To clarify, this was just an FYI comment. I expec Show quoted text On 2015/01/07 01:18:43, eroman wrote: > This is an unexpected error message -- it should instead say the operation is > unsupported if we are to go by the spec's interpretation. To clarify, this was just an FYI comment. I expect you to leave it as-is in this changelist, however perhaps add a FIXME linking to a bug. (the exception type is correct, so it is spec compliant with or without a more descriptive error message). In fact I would prefer to keep any fix in a subsequent changelist.
	9 PASS successfullyParsed is true

	10

	11 TEST COMPLETE

	12

OLD	NEW