LayoutTests/crypto/subtle/hkdf-importKey.html - Issue 822083003: Webcrypto: add layout tests for HKDF algorithm

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/crypto/subtle/hkdf-importKey.html

Issue 822083003: Webcrypto: add layout tests for HKDF algorithm (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/crypto/subtle/hkdf-deriveKey.html ('K') | « LayoutTests/crypto/subtle/hkdf-deriveKey-expected.txt ('k') | LayoutTests/crypto/subtle/hkdf-importKey-expected.txt » ('j') | LayoutTests/crypto/subtle/hkdf-importKey-expected.txt » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 <script src="resources/common.js"></script>

	6 </head>

	7 <body>

	8 <p id="description"></p>

	9 <div id="console"></div>

	10

	11 <script>

	12 description("Test bad inputs to HKDF deriveBits()");

	13

	14 jsTestIsAsync = true;

	15

	16 var extractable = true;

	17 raw_bytes = new Uint8Array([1, 2]);

	18

	19 var p = Promise.resolve(null);

	20 p.then(function() {

	21 debug("\nimportKey() with bad usages...");

	22 return crypto.subtle.importKey("raw", raw_bytes, "HKDF", extractable, ['encryp t']);

	23 }).then(failAndFinishJSTest, function(result) {

	24 logError(result);

	25

	26 debug("\nimportKey() with null key...");

	27 return crypto.subtle.importKey("raw", null, "HKDF", extractable, ['deriveKey'] );

	28 }).then(failAndFinishJSTest, function(result) {

	29 logError(result);

	30

	31 debug("\nimportKey() with jwk type...");

	32 return crypto.subtle.importKey("jwk", raw_bytes, "HKDF", extractable, ['derive Key']);
	eroman 2014/12/23 23:29:39 This is a fine test to have, but I don't think it This is a fine test to have, but I don't think it is testing what you think it is. Also add a test with valid JWK input. Is it expected that JWK import is not allowed for HKDF? nharper 2015/01/06 23:51:59 Changed the test to have valid JWK input. It is ex Show quoted text On 2014/12/23 23:29:39, eroman wrote: > This is a fine test to have, but I don't think it is testing what you think it > is. > > Also add a test with valid JWK input. > > Is it expected that JWK import is not allowed for HKDF? Changed the test to have valid JWK input. It is expected that JWK import is not allowed for HKDF.
	33 }).then(failAndFinishJSTest, function(result) {

	34 logError(result);

	35

	36 debug("\nimportKey() with spki type...");

	37 return crypto.subtle.importKey("spki", raw_bytes, "HKDF", extractable, ['deriv eKey']);

	38 }).then(failAndFinishJSTest, function(result) {

	39 logError(result);

	40

	41 debug("\nimportKey() with empty usages...");

	42 return crypto.subtle.importKey("raw", raw_bytes, "HKDF", extractable, []);

	43 }).then(failAndFinishJSTest, function(result) {

	44 logError(result);

	45

	46 debug("\nimportKey() correctly");

	47 return crypto.subtle.importKey("raw", raw_bytes, "HKDF", extractable, ['derive Key']);

	48 }).then(finishJSTest, failAndFinishJSTest);

	49

	50 </script>

	51

	52 </body>

	53 </html>

OLD	NEW