Issue 822005: Fix a crash reported in ChromeFrame on the crash server, which occurs because...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 822005: Fix a crash reported in ChromeFrame on the crash server, which occurs because... (Closed)

Created:
10 years, 9 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
amit

CC:
chromium-reviews, amit

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix a crash reported in ChromeFrame on the crash server, which occurs because the VARIANT representing the URL has a NULL bstrVal. Fix is to check for the same. Fixes bug http://code.google.com/p/chromium/issues/detail?id=37872 Bug=37872 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41208

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -10 lines)			Patch
	M	chrome_frame/bho.cc	View	1 2	1 chunk	+15 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

amit

10 years, 9 months ago (2010-03-10 20:10:00 UTC) #2

lg

http://codereview.chromium.org/822005/diff/4001/5001
File chrome_frame/bho.cc (right):

http://codereview.chromium.org/822005/diff/4001/5001#newcode106
chrome_frame/bho.cc:106: if (url->vt != VT_BSTR || url->bstrVal == NULL) {
nit: We could check this at the top. Nothing else need to be done otherwise.
Also, safer to check for url first b4 checking for url->vt.

Expand Messages | Collapse Messages