Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 821903003: Add sdefresne as temporary OWNERS of favicon & favicon_base (Closed)

Created:
5 years, 11 months ago by sdefresne
Modified:
5 years, 11 months ago
Reviewers:
sky, blundell
CC:
chromium-reviews, droger, jif
Base URL:
https://chromium.googlesource.com/chromium/src.git@favicon-base
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add sdefresne as temporary OWNERS of favicon & favicon_base Add sdefresne as temporary OWNERS of favicon & favicon_base for the duration of the componentization effort of favicon. Add OWNERS file to //components/favicon_base with the same OWNERS as //components/favicon since this component is there to help split functionality shared by history and favicon components. Remove blundell@ as temporary OWNERS of //components/favicon* since he is already OWNERS of //components. BUG=359513 Committed: https://crrev.com/53d0453cfaf186beb6163c7f8980b475e0185293 Cr-Commit-Position: refs/heads/master@{#311441}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M components/OWNERS View 1 chunk +1 line, -3 lines 0 comments Download
M components/favicon/OWNERS View 1 chunk +4 lines, -1 line 0 comments Download
A components/favicon_base/OWNERS View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
sdefresne
sky, blundell: can you take a look. sky: I can also be full OWNERS of ...
5 years, 11 months ago (2015-01-13 15:42:27 UTC) #2
blundell
lgtm
5 years, 11 months ago (2015-01-13 16:53:27 UTC) #3
sky
LGTM
5 years, 11 months ago (2015-01-13 18:40:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821903003/1
5 years, 11 months ago (2015-01-14 09:14:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 10:11:23 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 10:12:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/53d0453cfaf186beb6163c7f8980b475e0185293
Cr-Commit-Position: refs/heads/master@{#311441}

Powered by Google App Engine
This is Rietveld 408576698