ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc - Issue 821803002: Use XGrabPointer instead of XChangeActivatePointerGrab() to change the cursor during a pointer grab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

Issue 821803002: Use XGrabPointer instead of XChangeActivatePointerGrab() to change the cursor during a pointer grab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_capture

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/views/views.gyp ('k') | ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11_unittest.cc » ('j') | ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

diff --git a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

index 8a56b8de9689f8132adc9f2190b3154f4dced4b0..28323f0dd580d10a0f667f03af4c7a27f31d3b75 100644

--- a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

+++ b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc

@@ -694,8 +694,8 @@ int DesktopDragDropClientAuraX11::StartDragAndDrop(

// Windows has a specific method, DoDragDrop(), which performs the entire

// drag. We have to emulate this, so we spin off a nested runloop which will

// track all cursor movement and reroute events to a specific handler.

- move_loop_->RunMoveLoop(

- source_window,

+ move_loop_->RunMoveLoop(source_window);

+ move_loop_->UpdateCursor(

cursor_manager_->GetInitializedCursor(ui::kCursorGrabbing));

sadrul 2015/01/16 15:38:09 Is this going to do the right thing (i.e. would th

if (alive) {