Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 821793002: Chromecast on Android buildfix: don't try to create a RendererFactory. (Closed)

Created:
6 years ago by gunsch
Modified:
6 years ago
Reviewers:
erickung1
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromecast on Android buildfix: don't try to create a RendererFactory. The CMA code is not linked in for Android builds. R=erickung@chromium.org TBR=lcwu@chromium.org BUG=None Committed: https://crrev.com/8fb7fbcb06fb1f858efbfe7063cf89a07978ff27 Cr-Commit-Position: refs/heads/master@{#309492}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chromecast/renderer/cast_content_renderer_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chromecast/renderer/cast_content_renderer_client.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
gunsch
6 years ago (2014-12-22 21:35:04 UTC) #1
erickung1
On 2014/12/22 21:35:04, gunsch wrote: LGTM
6 years ago (2014-12-22 22:36:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821793002/1
6 years ago (2014-12-22 22:38:39 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years ago (2014-12-22 22:38:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821793002/1
6 years ago (2014-12-22 22:50:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 23:52:37 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-22 23:54:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fb7fbcb06fb1f858efbfe7063cf89a07978ff27
Cr-Commit-Position: refs/heads/master@{#309492}

Powered by Google App Engine
This is Rietveld 408576698