Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 821723002: Fix sourceURL & sourceMapURL handling in case of background parsing (Closed)

Created:
6 years ago by sergeyv
Modified:
5 years, 11 months ago
Reviewers:
yurys, marja
CC:
v8-dev
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix sourceURL & sourceMapURL handling in case of background parsing BUG= Committed: https://crrev.com/cedc11ba593250f0e726ccafde9a3d5d52db844d Cr-Commit-Position: refs/heads/master@{#25980}

Patch Set 1 #

Patch Set 2 : Test added #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -7 lines) Patch
M src/api.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 5 chunks +37 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
yurys
Looks fine but needs a test.
6 years ago (2014-12-23 12:32:22 UTC) #2
sergeyv
On 2014/12/23 12:32:22, yurys wrote: > Looks fine but needs a test. Tests were added
6 years ago (2014-12-23 15:04:09 UTC) #3
yurys
lgtm
6 years ago (2014-12-23 15:19:36 UTC) #4
sergeyv
5 years, 12 months ago (2014-12-24 10:28:57 UTC) #6
marja
lgtm I was actually surprised that Internalize() doesn't call HandleSourceURLComments, and I was wondering why.. ...
5 years, 11 months ago (2014-12-29 20:01:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821723002/20001
5 years, 11 months ago (2014-12-31 12:55:25 UTC) #11
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true in order for the CQ ...
5 years, 11 months ago (2014-12-31 12:55:27 UTC) #13
marja
Hmm, something's wrong with this CL. machenbach@, does the CQ error message ring a bell?
5 years, 11 months ago (2015-01-06 09:28:55 UTC) #14
Michael Achenbach
This has been sent from an old svn checkout. You need to reupload the CL ...
5 years, 11 months ago (2015-01-07 09:33:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821723002/40001
5 years, 11 months ago (2015-01-07 15:28:08 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-07 15:56:18 UTC) #18
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 15:56:29 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cedc11ba593250f0e726ccafde9a3d5d52db844d
Cr-Commit-Position: refs/heads/master@{#25980}

Powered by Google App Engine
This is Rietveld 408576698