Hide "result-headers" on mobile when empty

Hide "result-headers" on mobile when empty

When no search term are entered, remove the "result-headers" on mobile
as otherwise it looks incorrect. Use :empty CSS pseudo selector.

BUG=440368
Committed: https://crrev.com/c5278d7b93cd4cd3adf1c1ed502b04d248e39ad3
Cr-Commit-Position: refs/heads/master@{#309624}

[sdefresne, 2014-12-22 17:11:18]

Please take a look.

[Dan Beam, 2014-12-22 19:35:14]

can we make this element collapse if it has no text?  that way we don't have to
keep the display in sync with the text content.  maybe just try making it
display: inline-block?

[sdefresne, 2014-12-23 10:43:06]

On 2014/12/22 at 19:35:14, dbeam wrote:
> can we make this element collapse if it has no text?  that way we don't have
to keep the display in sync with the text content.  maybe just try making it
display: inline-block?

I tried "display: inline-block" but it is ugly. Instead I've used the ":empty"
CSS pseudo selector to set "display: none" when the div does not contain text.
Let CSS track the text content of the div ;-)

Please take another look.

[Dan Beam, 2014-12-23 18:03:44]

https://codereview.chromium.org/821703003/diff/20001/chrome/browser/resources...
File chrome/browser/resources/history/history.css (right):

https://codereview.chromium.org/821703003/diff/20001/chrome/browser/resources...
chrome/browser/resources/history/history.css:641: #results-header:empty {
add this to history_mobile.css instead

[Dan Beam, 2014-12-23 18:04:40]

lgtm assuming you put these 3 lines into history_mobile.css

[sdefresne, 2014-12-24 08:38:35]

On 2014/12/23 at 18:04:40, dbeam wrote:
> lgtm assuming you put these 3 lines into history_mobile.css

Thank you, done.

[sdefresne, 2014-12-24 08:38:39]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-12-24 08:38:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/821703003/40001

[commit-bot: I haz the power, 2014-12-24 09:25:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-24 09:25:59]

Patchset 3 (id:??) landed as
https://crrev.com/c5278d7b93cd4cd3adf1c1ed502b04d248e39ad3
Cr-Commit-Position: refs/heads/master@{#309624}

[Dan Beam, 2014-12-24 19:00:48]

https://codereview.chromium.org/821703003/diff/40001/chrome/browser/resources...
File chrome/browser/resources/history/history_mobile.css (right):

https://codereview.chromium.org/821703003/diff/40001/chrome/browser/resources...
chrome/browser/resources/history/history_mobile.css:320: display: none;
why did you put this for ios only?  doesn't this affect android as well?

[sdefresne, 2014-12-26 09:42:08]

https://codereview.chromium.org/821703003/diff/40001/chrome/browser/resources...
File chrome/browser/resources/history/history_mobile.css (right):

https://codereview.chromium.org/821703003/diff/40001/chrome/browser/resources...
chrome/browser/resources/history/history_mobile.css:320: display: none;
On 2014/12/24 at 19:00:48, Dan Beam wrote:
> why did you put this for ios only?  doesn't this affect android as well?

The original bug was reported against iOS and I cannot find a corresponding bug
reported against android, nor do I have a recent build of android to test.