Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 821683002: Print out failing PathRef test on ChromeOS (Closed)

Created:
6 years ago by robertphillips
Modified:
5 years, 11 months ago
Reviewers:
reed1
CC:
reed1
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Print out failing PathRef test on ChromeOS This is intended to provide additional information for a flaky assertion failure on ChromeOS Daisy. BUG=skia:3282 Committed: https://skia.googlesource.com/skia/+/f1cdead599715dbae30278bffa4528bd1664f61f

Patch Set 1 #

Patch Set 2 : Add SK_DEBUG wrapper #

Patch Set 3 : Fix bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M src/core/SkPathRef.cpp View 1 2 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
robertphillips
6 years ago (2014-12-22 17:06:47 UTC) #1
reed1
lgtm
5 years, 11 months ago (2015-01-05 16:49:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821683002/40001
5 years, 11 months ago (2015-01-05 17:11:10 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 17:20:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f1cdead599715dbae30278bffa4528bd1664f61f

Powered by Google App Engine
This is Rietveld 408576698