Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1418)

Unified Diff: src/utils/debugger/SkDebugCanvas.h

Issue 821663003: Change DebugCanvas API to not encourage memory leaks (Closed) Base URL: https://skia.googlesource.com/skia.git@debugger-raster-black-bg
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/utils/debugger/SkDebugCanvas.h
diff --git a/src/utils/debugger/SkDebugCanvas.h b/src/utils/debugger/SkDebugCanvas.h
index 18f4c8d71336a4c22f648f13e546fe3bad66d07e..b064389fb5c0e8108f53c38f33fd9bad9c0f96c8 100644
--- a/src/utils/debugger/SkDebugCanvas.h
+++ b/src/utils/debugger/SkDebugCanvas.h
@@ -123,14 +123,14 @@ public:
SkTDArray<SkDrawCommand*>& getDrawCommands();
/**
- * Returns the string vector of draw commands
+ * Fills the string vector with draw commands
*/
- SkTArray<SkString>* getDrawCommandsAsStrings() const;
+ void getDrawCommandsAsStrings(SkTArray<SkString>* outCommandStrings) const;
/**
- * Returns an array containing an offset (in the SkPicture) for each command
+ * Fills the size_t array with an offset (in the SkPicture) for each command
*/
- SkTDArray<size_t>* getDrawCommandOffsets() const;
+ void getDrawCommandOffsets(SkTDArray<size_t>* outCommandOffsets) const;
/**
Returns length of draw command vector.

Powered by Google App Engine
This is Rietveld 408576698