Change DebugCanvas API to not encourage memory leaks

Change DebugCanvas API to not encourage memory leaks

Pass command strings and offset arrays as out parameters instead of
returning new arrays from the functions.

This simplifies debugger leak investigations, as the app leaks less by
design.

Committed: https://skia.googlesource.com/skia/+/5037e9de94e57d36592cc596d831cc2b5ec45bd3

[Kimmo Kinnunen, 2014-12-22 11:10:57]

kkinnunen@nvidia.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2014-12-22 15:25:36]

lgtm + suggestion

https://codereview.chromium.org/821663003/diff/1/src/utils/debugger/SkDebugCa...
File src/utils/debugger/SkDebugCanvas.cpp (right):

https://codereview.chromium.org/821663003/diff/1/src/utils/debugger/SkDebugCa...
src/utils/debugger/SkDebugCanvas.cpp:397: }
else {
    outCommands->reset();
}

??

[Kimmo Kinnunen, 2014-12-29 07:23:13]

https://codereview.chromium.org/821663003/diff/1/src/utils/debugger/SkDebugCa...
File src/utils/debugger/SkDebugCanvas.cpp (right):

https://codereview.chromium.org/821663003/diff/1/src/utils/debugger/SkDebugCa...
src/utils/debugger/SkDebugCanvas.cpp:397: }
On 2014/12/22 15:25:36, robertphillips wrote:
> else {
>     outCommands->reset();
> }
> 
> ??

it tried to do that with resize_back(count), in case when count would be 0.

I posted another patch, would that be clearer?

[robertphillips, 2014-12-30 15:12:38]

lgtm

[robertphillips, 2014-12-30 15:12:41]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-12-30 15:13:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/821663003/40001

[commit-bot: I haz the power, 2014-12-30 15:23:01]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/5037e9de94e57d36592cc596d831cc2b5ec45bd3