Issue 821643007: Fix inspector unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 821643007: Fix inspector unittests. (Closed)

Created:
5 years, 11 months ago by tonyg

Modified:
5 years, 11 months ago

Reviewers:
ojan, jamesr, esprehn, abarth-chromium

CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	sky/framework/inspector/dom-agent.sky	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

abarth-chromium

A better fix would be to remove the things that are trying to extend DOMAgent.

5 years, 11 months ago (2015-01-14 19:00:33 UTC) #4

tonyg

Good call. There was an uninitialized member that was added by enable().

5 years, 11 months ago (2015-01-14 19:24:59 UTC) #5

tonyg

5 years, 11 months ago (2015-01-14 19:32:34 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
86fd5df86af604d7ea66b058d02028622de09d5c (presubmit successful).