Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 821643006: upstream hooking into google3 crash handler for better stacktraces (Closed)

Created:
5 years, 11 months ago by mtklein_C
Modified:
5 years, 11 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

upstream hooking into google3 crash handler for better stacktraces BUG=skia: Committed: https://skia.googlesource.com/skia/+/b47bba7c77782a9ee9e7d67a4b9c68050263e68a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/CrashHandler.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
5 years, 11 months ago (2015-01-14 13:56:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821643006/1
5 years, 11 months ago (2015-01-14 13:57:05 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-14 13:57:06 UTC) #5
jcgregorio
lgtm
5 years, 11 months ago (2015-01-14 14:37:41 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 14:38:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b47bba7c77782a9ee9e7d67a4b9c68050263e68a

Powered by Google App Engine
This is Rietveld 408576698