Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: chromeos/network/managed_network_configuration_handler_unittest.cc

Issue 821643005: Provide GUID in ONC for all networks in ManagedNetworkConfigurationHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix chromeos_unittests Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/managed_network_configuration_handler_impl.cc ('k') | chromeos/network/onc/onc_merger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/managed_network_configuration_handler_unittest.cc
diff --git a/chromeos/network/managed_network_configuration_handler_unittest.cc b/chromeos/network/managed_network_configuration_handler_unittest.cc
index d40abda441aaee9a1bafd57221f247561e6146b1..5c79227e7a78e0448f84c1e0d1aa81a48cb4b6c9 100644
--- a/chromeos/network/managed_network_configuration_handler_unittest.cc
+++ b/chromeos/network/managed_network_configuration_handler_unittest.cc
@@ -21,6 +21,7 @@
#include "chromeos/network/network_configuration_handler.h"
#include "chromeos/network/network_policy_observer.h"
#include "chromeos/network/network_profile_handler.h"
+#include "chromeos/network/network_state_handler.h"
#include "chromeos/network/onc/onc_test_utils.h"
#include "chromeos/network/onc/onc_utils.h"
#include "dbus/object_path.h"
@@ -241,15 +242,16 @@ class ManagedNetworkConfigurationHandlerTest : public testing::Test {
.WillByDefault(Invoke(&services_stub_,
&ShillServiceTestClient::GetProperties));
+ network_state_handler_.reset(NetworkStateHandler::InitializeForTest());
network_profile_handler_.reset(new TestNetworkProfileHandler());
network_configuration_handler_.reset(
NetworkConfigurationHandler::InitializeForTest(
- NULL /* no NetworkStateHandler */,
+ network_state_handler_.get(),
NULL /* no NetworkDeviceHandler */));
managed_network_configuration_handler_.reset(
new ManagedNetworkConfigurationHandlerImpl());
managed_network_configuration_handler_->Init(
- NULL /* no NetworkStateHandler */,
+ network_state_handler_.get(),
network_profile_handler_.get(),
network_configuration_handler_.get(),
NULL /* no DeviceHandler */);
@@ -261,6 +263,7 @@ class ManagedNetworkConfigurationHandlerTest : public testing::Test {
void TearDown() override {
if (managed_network_configuration_handler_)
managed_network_configuration_handler_->RemoveObserver(&policy_observer_);
+ network_state_handler_.reset();
managed_network_configuration_handler_.reset();
network_configuration_handler_.reset();
network_profile_handler_.reset();
@@ -360,6 +363,7 @@ class ManagedNetworkConfigurationHandlerTest : public testing::Test {
ShillProfileTestClient profiles_stub_;
ShillServiceTestClient services_stub_;
TestNetworkPolicyObserver policy_observer_;
+ scoped_ptr<NetworkStateHandler> network_state_handler_;
scoped_ptr<TestNetworkProfileHandler> network_profile_handler_;
scoped_ptr<NetworkConfigurationHandler> network_configuration_handler_;
scoped_ptr<ManagedNetworkConfigurationHandlerImpl>
« no previous file with comments | « chromeos/network/managed_network_configuration_handler_impl.cc ('k') | chromeos/network/onc/onc_merger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698