Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 821623002: Combine resources at video_player/js/compiled_resources.gyp for closure compiler. (Closed)

Created:
6 years ago by yawano
Modified:
6 years ago
Reviewers:
hirono
CC:
chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Combine resources at video_player/js/compiled_resources.gyp for closure compiler. The reason for this change is same as http://crrev.com/806393002. BUG=444485 TEST=GYP_GENERATORS=ninja tools/gyp/gyp --depth . ui/file_manager/video_player/js/compiled_resources.gyp && ninja -C out/Default Committed: https://crrev.com/50a9f30dd5a988db609d8b727d6e956dfd00b50c Cr-Commit-Position: refs/heads/master@{#309404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M ui/file_manager/video_player/js/compiled_resources.gyp View 1 chunk +28 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
PTAL. Thank you!
6 years ago (2014-12-22 04:57:07 UTC) #2
hirono
lgtm!
6 years ago (2014-12-22 05:40:28 UTC) #3
yawano
On 2014/12/22 05:40:28, hirono wrote: > lgtm! Thank you!
6 years ago (2014-12-22 05:47:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821623002/1
6 years ago (2014-12-22 05:48:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 07:32:17 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-22 07:33:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50a9f30dd5a988db609d8b727d6e956dfd00b50c
Cr-Commit-Position: refs/heads/master@{#309404}

Powered by Google App Engine
This is Rietveld 408576698