Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 821543002: Revert of Roll pdfium to 59dffb68f07c7ce583285a23ad580b768ce3cd3e (Closed)

Created:
6 years ago by Michael Achenbach
Modified:
6 years ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll pdfium to 59dffb68f07c7ce583285a23ad580b768ce3cd3e (patchset #2 id:20001 of https://codereview.chromium.org/815353002/) Reason for revert: Breaks compilation on Win8 GN: http://build.chromium.org/p/chromium.win/buildstatus?builder=Win8%20GN&number=2381 Original issue's description: > Roll pdfium to 59dffb68f07c7ce583285a23ad580b768ce3cd3e > > 59dffb6 Fix new third_party/BUILD.gn to use the right build config. > 06b087a Set the freetype options missing in the recent update. > b3a3230 Add the license back to ftmodule.h after the freetype 2.5.4 upgrade. > a09d50d Transform font size to user space for valid text size comparison. > e4fc5ce Update freetype to 2.5.4. > > BUG=407341, 438441, 444243 > TBR=tsepez@chromium.org > > Committed: https://crrev.com/43a66cb1bff61ab967d767160287c0d9129128b8 > Cr-Commit-Position: refs/heads/master@{#309342} TBR=tsepez@chromium.org,thestig@chromium.org NOTREECHECKS=true NOTRY=true BUG=407341, 438441, 444243 Committed: https://crrev.com/289ea6c7d564793dbdf10c26200b8eec590d05b2 Cr-Commit-Position: refs/heads/master@{#309344}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Roll pdfium to 59dffb68f07c7ce583285a23ad580b768ce3cd3e
6 years ago (2014-12-20 15:57:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821543002/1
6 years ago (2014-12-20 15:58:22 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-20 15:59:35 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-20 16:00:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/289ea6c7d564793dbdf10c26200b8eec590d05b2
Cr-Commit-Position: refs/heads/master@{#309344}

Powered by Google App Engine
This is Rietveld 408576698