components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc - Issue 821453003: Update legacy Tuple-using code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

Issue 821453003: Update legacy Tuple-using code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc ('k') | components/password_manager/content/renderer/credential_manager_client_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

diff --git a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

index 9d64b9edd15fb0f077b877a05aa235c395a93ef2..0b782e70157659f3958fba886222c22d32bf5927 100644

--- a/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

+++ b/components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc

@@ -234,7 +234,7 @@ TEST_F(ContentCredentialManagerDispatcherTest,

EXPECT_TRUE(message);

CredentialManagerMsg_SendCredential::Param param;

CredentialManagerMsg_SendCredential::Read(message, &param);

- EXPECT_EQ(CREDENTIAL_TYPE_EMPTY, param.b.type);

+ EXPECT_EQ(CREDENTIAL_TYPE_EMPTY, get<1>(param).type);

process()->sink().ClearMessages();

EXPECT_FALSE(client_->did_prompt_user_to_choose());

}

@@ -254,7 +254,7 @@ TEST_F(ContentCredentialManagerDispatcherTest,

EXPECT_TRUE(message);

CredentialManagerMsg_SendCredential::Param param;

CredentialManagerMsg_SendCredential::Read(message, &param);

- EXPECT_EQ(CREDENTIAL_TYPE_EMPTY, param.b.type);

+ EXPECT_EQ(CREDENTIAL_TYPE_EMPTY, get<1>(param).type);

process()->sink().ClearMessages();

EXPECT_FALSE(client_->did_prompt_user_to_choose());

}

@@ -291,7 +291,7 @@ TEST_F(ContentCredentialManagerDispatcherTest,

CredentialManagerMsg_RejectCredentialRequest::Param reject_param;

CredentialManagerMsg_RejectCredentialRequest::Read(message, &reject_param);

EXPECT_EQ(blink::WebCredentialManagerError::ErrorTypePendingRequest,

- reject_param.b);

+ get<1>(reject_param));

EXPECT_FALSE(client_->did_prompt_user_to_choose());

process()->sink().ClearMessages();

@@ -305,8 +305,7 @@ TEST_F(ContentCredentialManagerDispatcherTest,

EXPECT_TRUE(message);

CredentialManagerMsg_SendCredential::Param send_param;

CredentialManagerMsg_SendCredential::Read(message, &send_param);

- CredentialManagerMsg_SendCredential::Read(message, &send_param);

- EXPECT_NE(CREDENTIAL_TYPE_EMPTY, send_param.b.type);

+ EXPECT_NE(CREDENTIAL_TYPE_EMPTY, get<1>(send_param).type);

process()->sink().ClearMessages();

EXPECT_TRUE(client_->did_prompt_user_to_choose());

}