chrome/browser/extensions/api/web_request/web_request_api_unittest.cc - Issue 821453003: Update legacy Tuple-using code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

Issue 821453003: Update legacy Tuple-using code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: media Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/observer_list_threadsafe.h ('K') | « chrome/browser/extensions/api/alarms/alarms_api_unittest.cc ('k') | chrome/browser/extensions/sandboxed_unpacker.cc » ('j') | components/password_manager/content/browser/content_credential_manager_dispatcher_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

index 046b6728be20e64fc73cf0d7270c9a2a80576d3c..26d08679c72c1d1712f601ecf59276f24bd047b4 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

@@ -120,9 +120,9 @@ void GetPartOfMessageArguments(IPC::Message* message,

ExtensionMsg_MessageInvoke::Param* param) {

ASSERT_EQ(ExtensionMsg_MessageInvoke::ID, message->type());

ASSERT_TRUE(ExtensionMsg_MessageInvoke::Read(message, param));

- ASSERT_GE(param->d.GetSize(), 2u);

+ ASSERT_GE(get<3>(*param).GetSize(), 2u);

const base::Value* value = NULL;

- ASSERT_TRUE(param->d.Get(1, &value));

+ ASSERT_TRUE(get<3>(*param).Get(1, &value));

const base::ListValue* list = NULL;

ASSERT_TRUE(value->GetAsList(&list));

ASSERT_EQ(1u, list->GetSize());

@@ -920,7 +920,7 @@ TEST_P(ExtensionWebRequestHeaderModificationTest, TestModifications) {

continue;

ExtensionMsg_MessageInvoke::Param message_tuple;

ExtensionMsg_MessageInvoke::Read(message, &message_tuple);

- base::ListValue& args = message_tuple.d;

+ base::ListValue& args = get<3>(message_tuple);

std::string event_name;

if (!args.GetString(0, &event_name) ||