Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 821403003: Changes magic sequence to '!#mojo ' and strips 'mojo ' when building url (Closed)

Created:
5 years, 11 months ago by sky
Modified:
5 years, 11 months ago
Reviewers:
Aaron Boodman, Hixie
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Changes magic sequence to '!#mojo ' and strips 'mojo ' when building url Prior to this change the magic sequence was '#!mojo:' and the url of the content handler app included mojo:. This works only for mojo: urls, but we want other schemes. So, the magic sequence is now '#!mojo ' and 'mojo ' is not part of the resulting url. R=aa@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/05833db1b922104838d2d7e128ff601b2b3461ec

Patch Set 1 #

Patch Set 2 : : -> ' ' #

Patch Set 3 : merge 2 trunk #

Patch Set 4 : two more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M examples/js/cube.js View 1 1 chunk +1 line, -1 line 0 comments Download
M examples/js/hello.js View 1 1 chunk +1 line, -1 line 0 comments Download
M examples/js/share_echo.js View 1 1 chunk +1 line, -1 line 0 comments Download
M examples/js/share_echo_target.js View 1 1 chunk +1 line, -1 line 0 comments Download
M examples/js/users-guide.md View 1 4 chunks +4 lines, -4 lines 0 comments Download
M examples/js/wget.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M examples/js/world.js View 1 1 chunk +1 line, -1 line 0 comments Download
M examples/recipes/recipe_handler/sample View 1 1 chunk +1 line, -1 line 0 comments Download
M examples/window_manager/debug_panel.sky View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M examples/wm_flow/wm/window_frame.sky View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/mojo_application.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M services/js/test/echo.js View 1 1 chunk +1 line, -1 line 0 comments Download
M services/js/test/network_test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M services/js/test/pingpong.js View 1 1 chunk +1 line, -1 line 0 comments Download
M services/js/test/pingpong_target.js View 1 1 chunk +1 line, -1 line 0 comments Download
M shell/dynamic_application_loader.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M sky/examples/home.sky View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
sky
5 years, 11 months ago (2015-01-07 23:30:29 UTC) #1
Aaron Boodman
+hixie wow, that sure looks weird, but I agree with you... Hixie, am I forgetting ...
5 years, 11 months ago (2015-01-08 01:09:34 UTC) #3
abarth-chromium
On 2015/01/08 at 01:09:34, aa wrote: > +hixie > > wow, that sure looks weird, ...
5 years, 11 months ago (2015-01-08 04:19:18 UTC) #4
Aaron Boodman
Oh yeah, that's it. That would make it less weird: #!mojo mojo:monkey Or: #!mojo http://monkey.com/
5 years, 11 months ago (2015-01-08 05:40:50 UTC) #5
sky
Indeed the space makes things look better. Updated.
5 years, 11 months ago (2015-01-08 14:27:28 UTC) #6
Aaron Boodman
On 2015/01/08 14:27:28, sky wrote: > Indeed the space makes things look better. Updated. Lgtm
5 years, 11 months ago (2015-01-08 16:43:58 UTC) #7
sky
5 years, 11 months ago (2015-01-08 18:19:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
05833db1b922104838d2d7e128ff601b2b3461ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698