Wrap ContentView in a parent view to fix infobar accessibility.

Wrap ContentView in a parent view to fix infobar accessibility.

Previously, it was impossible to select infobars when using explore by
touch and traversing through the views using forward and backward
swipes. The problem was that ContentView contained both the
InfoBarContainer (a real View) as well as virtual views for all the
elements in the webpage -- but Android doesn't support ViewGroups that
contain both real and virtual views.

The fix is to add a FrameLayout, which is now a common parent of both
the ContentView and the InfoBarContainer. Here's the new view hierarchy:

  CompositorViewHolder
           |
      FrameLayout
       |        \
  ContentView  InfoBarContainer

Tab.getView() now returns the parent FrameLayout, rather than the
ContentView itself.

BUG=416663
Committed: https://crrev.com/2f93e319a2c8b6a047d1ec6fd974b381681a916d
Cr-Commit-Position: refs/heads/master@{#310125}

[newt (away), 2015-01-06 03:40:53]

newt@chromium.org changed reviewers:
+ dtrainor@chromium.org, tedchoc@chromium.org

[newt (away), 2015-01-06 03:40:53]

PTAL

[newt (away), 2015-01-06 03:44:43]

https://codereview.chromium.org/821393004/diff/1/chrome/android/java/src/org/...
File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):

https://codereview.chromium.org/821393004/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1120: 
will remove this random empty line

[Ted C, 2015-01-06 17:20:20]

lgtm

[Ted C, 2015-01-06 18:13:40]

https://codereview.chromium.org/821393004/diff/40001/chrome/android/java/src/...
File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):

https://codereview.chromium.org/821393004/diff/40001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1295:
mContentViewParent = new FrameLayout(mContext);
do we want to assert that mContentViewParent == null above here?  Just to make
sure we're not leaking one.

[newt (away), 2015-01-06 18:15:55]

On 2015/01/06 18:13:40, Ted C wrote:
>
https://codereview.chromium.org/821393004/diff/40001/chrome/android/java/src/...
> File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):
> 
>
https://codereview.chromium.org/821393004/diff/40001/chrome/android/java/src/...
> chrome/android/java/src/org/chromium/chrome/browser/Tab.java:1295:
> mContentViewParent = new FrameLayout(mContext);
> do we want to assert that mContentViewParent == null above here?  Just to make
> sure we're not leaking one.

Done.

[newt (away), 2015-01-06 18:18:33]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-01-06 18:19:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/821393004/60001

[newt (away), 2015-01-06 18:34:14]

The CQ bit was unchecked by newt@chromium.org

[newt (away), 2015-01-06 19:19:33]

The CQ bit was checked by newt@chromium.org

[commit-bot: I haz the power, 2015-01-06 19:20:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/821393004/80001

[commit-bot: I haz the power, 2015-01-06 20:11:11]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-01-06 20:13:44]

Patchset 5 (id:??) landed as
https://crrev.com/2f93e319a2c8b6a047d1ec6fd974b381681a916d
Cr-Commit-Position: refs/heads/master@{#310125}