Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 821383009: Correctly parse line ends for debugging. (Closed)

Created:
5 years, 11 months ago by Yang
Modified:
5 years, 11 months ago
Reviewers:
marja
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correctly parse line ends for debugging. Instead of using only \n as line terminator, we now use the definition in http://www.ecma-international.org/ecma-262/5.1/#sec-7.3 R=marja@chromium.org BUG=v8:2825 LOG=Y Committed: https://crrev.com/2050994d8029a0fb80cd962d56eda581c16badd8 Cr-Commit-Position: refs/heads/master@{#25989}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -14 lines) Patch
M src/objects.cc View 1 1 chunk +12 lines, -14 lines 0 comments Download
M src/scanner.h View 1 chunk +6 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-2825.js View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
5 years, 11 months ago (2015-01-07 12:39:51 UTC) #1
marja
lgtm
5 years, 11 months ago (2015-01-07 12:50:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821383009/1
5 years, 11 months ago (2015-01-07 12:53:07 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/583) v8_linux64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2045) v8_linux_arm_rel ...
5 years, 11 months ago (2015-01-07 12:54:18 UTC) #6
Yang
Committed patchset #2 (id:20001) manually as 2050994d8029a0fb80cd962d56eda581c16badd8 (presubmit successful).
5 years, 11 months ago (2015-01-08 10:46:19 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 10:46:21 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2050994d8029a0fb80cd962d56eda581c16badd8
Cr-Commit-Position: refs/heads/master@{#25989}

Powered by Google App Engine
This is Rietveld 408576698