Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 821353003: Switch to SkyBinder (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, rafaelw
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Switch to SkyBinder SkyBinder is a rewrite of TemplateBinding.sky that uses classes and weak maps and doesn't add expandos to any of the DOM objects. It has a few differences from TemplateBinding.sky: - null doesn't create instances in repeats. - One time bindings are removed ([[ expr ]]), we'll add them back later. - The bind attribute is removed. The system is also less generic and is specialized to be used when creating SkyElement instances. The commit history that created SkyBinder can be found at: https://github.com/esprehn/sky-binder/commits/master TBR=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dabd9b681211d7d07ba1c7c3105c50a8408121ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+474 lines, -1038 lines) Patch
D sky/framework/sky-element/TemplateBinding.sky View 1 chunk +0 lines, -1036 lines 0 comments Download
A sky/framework/sky-element/sky-binder.sky View 1 chunk +471 lines, -0 lines 0 comments Download
M sky/framework/sky-element/sky-element.sky View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
esprehn
5 years, 11 months ago (2015-01-03 03:41:52 UTC) #2
esprehn
5 years, 11 months ago (2015-01-03 03:42:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dabd9b681211d7d07ba1c7c3105c50a8408121ff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698